From: Jim Kukunas <james.t.kukunas@linux.intel.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>, tom.zanussi@linux.intel.com
Cc: Arjan van de Ven <arjan@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
tglx@linutronix.de, mingo@redhat.com, x86@kernel.org
Subject: [PATCH 11/11] x86/xip: update _va() and _pa() macros
Date: Mon, 23 Mar 2015 00:46:40 -0700 [thread overview]
Message-ID: <1427096800-30452-12-git-send-email-james.t.kukunas@linux.intel.com> (raw)
In-Reply-To: <1427096800-30452-1-git-send-email-james.t.kukunas@linux.intel.com>
For obtaining the physical address, we always take the slow path
of slow_virt_to_phys(). In the future, we should probably special
case data addresses to avoid walking the page table. For obtaining
a virtual address, this patch introduces a slow path of
slow_xip_phys_to_virt().
Signed-off-by: Jim Kukunas <james.t.kukunas@linux.intel.com>
---
arch/x86/include/asm/page.h | 15 +++++++++++++++
arch/x86/mm/pageattr.c | 11 +++++++++++
2 files changed, 26 insertions(+)
diff --git a/arch/x86/include/asm/page.h b/arch/x86/include/asm/page.h
index 802dde3..b54c7be 100644
--- a/arch/x86/include/asm/page.h
+++ b/arch/x86/include/asm/page.h
@@ -6,6 +6,7 @@
#ifdef __KERNEL__
#include <asm/page_types.h>
+#include <asm/pgtable_types.h>
#ifdef CONFIG_X86_64
#include <asm/page_64.h>
@@ -37,8 +38,15 @@ static inline void copy_user_page(void *to, void *from, unsigned long vaddr,
alloc_page_vma(GFP_HIGHUSER | __GFP_ZERO | movableflags, vma, vaddr)
#define __HAVE_ARCH_ALLOC_ZEROED_USER_HIGHPAGE
+
+#ifdef CONFIG_XIP_KERNEL /* TODO special case text translations */
+#define __pa(x) slow_virt_to_phys((void *)(x))
+#define __pa_nodebug slow_virt_to_phys((void *)(x))
+#else
#define __pa(x) __phys_addr((unsigned long)(x))
#define __pa_nodebug(x) __phys_addr_nodebug((unsigned long)(x))
+#endif
+
/* __pa_symbol should be used for C visible symbols.
This seems to be the official gcc blessed way to do such arithmetic. */
/*
@@ -51,7 +59,14 @@ static inline void copy_user_page(void *to, void *from, unsigned long vaddr,
#define __pa_symbol(x) \
__phys_addr_symbol(__phys_reloc_hide((unsigned long)(x)))
+
+#ifdef CONFIG_XIP_KERNEL
+extern unsigned long slow_xip_phys_to_virt(phys_addr_t);
+
+#define __va(x) ((void *)slow_xip_phys_to_virt((phys_addr_t)x))
+#else
#define __va(x) ((void *)((unsigned long)(x)+PAGE_OFFSET))
+#endif
#define __boot_va(x) __va(x)
#define __boot_pa(x) __pa(x)
diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c
index 536ea2f..ca9e2ca 100644
--- a/arch/x86/mm/pageattr.c
+++ b/arch/x86/mm/pageattr.c
@@ -383,6 +383,17 @@ static pte_t *_lookup_address_cpa(struct cpa_data *cpa, unsigned long address,
return lookup_address(address, level);
}
+#ifdef CONFIG_XIP_KERNEL
+unsigned long slow_xip_phys_to_virt(phys_addr_t x)
+{
+ if (x >= CONFIG_XIP_BASE && x <= (phys_addr_t)phys_sdata) {
+ unsigned long off = x - CONFIG_XIP_BASE;
+ return PAGE_OFFSET + off;
+ }
+ return x + PAGE_OFFSET;
+}
+#endif
+
/*
* Lookup the PMD entry for a virtual address. Return a pointer to the entry
* or NULL if not present.
--
2.1.0
next prev parent reply other threads:[~2015-03-23 7:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 7:46 [RFC] x86 XIP Jim Kukunas
2015-03-23 7:46 ` [PATCH 01/11] x86/xip: add XIP_KERNEL and XIP_BASE options Jim Kukunas
2015-03-23 7:46 ` [PATCH 02/11] x86/xip: Update address of sections in linker script Jim Kukunas
2015-03-23 7:46 ` [PATCH 03/11] x86/xip: copy writable sections into RAM Jim Kukunas
2015-03-23 7:46 ` [PATCH 04/11] x86/xip: XIP boot trampoline page tables Jim Kukunas
2015-03-23 7:46 ` [PATCH 05/11] x86/xip: reserve memblock for only data Jim Kukunas
2015-03-23 7:46 ` [PATCH 06/11] x86/xip: after paging trampoline, discard PMDs above _brk Jim Kukunas
2015-03-23 7:46 ` [PATCH 07/11] x86/xip: make e820_add_kernel_range() a NOP Jim Kukunas
2015-03-23 7:46 ` [PATCH 08/11] x86/xip: in setup_arch(), handle resource physical addr Jim Kukunas
2015-03-23 7:46 ` [PATCH 09/11] x86/xip: snip the kernel text out of the memory mapping Jim Kukunas
2015-03-23 7:46 ` [PATCH 10/11] x86/xip: resolve alternative instructions at build Jim Kukunas
2015-03-23 8:33 ` Borislav Petkov
2015-03-23 8:38 ` Borislav Petkov
2015-03-25 0:50 ` Jim Kukunas
2015-03-25 8:44 ` Borislav Petkov
2015-03-23 22:40 ` Paul Bolle
2015-03-23 7:46 ` Jim Kukunas [this message]
2015-03-23 8:09 ` [PATCH 11/11] x86/xip: update _va() and _pa() macros Ingo Molnar
2015-03-23 15:09 ` Borislav Petkov
2015-03-23 8:07 ` [RFC] x86 XIP Ingo Molnar
2015-03-25 0:14 ` Jim Kukunas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427096800-30452-12-git-send-email-james.t.kukunas@linux.intel.com \
--to=james.t.kukunas@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tom.zanussi@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®