From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753302AbbCWMgo (ORCPT ); Mon, 23 Mar 2015 08:36:44 -0400 Received: from mx02.posteo.de ([89.146.194.165]:43419 "EHLO mx02.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752585AbbCWMgn (ORCPT ); Mon, 23 Mar 2015 08:36:43 -0400 From: Martin Kepplinger To: rusty@rustcorp.com.au Cc: lguest@lists.ozlabs.org, linux-kernel@vger.kernel.org, tomvanbraeckel@gmail.com, Martin Kepplinger Subject: [PATCH] lguest: explicitly set miscdevice's private_data NULL Date: Mon, 23 Mar 2015 13:36:08 +0100 Message-Id: <1427114168-32730-1-git-send-email-martink@posteo.de> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is a proposed change to the miscdevice's behaviour on open(). Currently file->private_data stays NULL, but only because we don't have an open-entry in struct file_operations. This may change so that private_data, more consistently, is always set to struct miscdevice, not only *if* the driver has it's own open() routine and fops-entry, see https://lkml.org/lkml/2014/12/4/939 and commit 94e4fe2cab3d43b3ba7c3f721743006a8c9d913a In short: If we rely on file->private_data being NULL, we should ensure it is NULL ourselves. Signed-off-by: Martin Kepplinger --- drivers/lguest/lguest_user.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/lguest/lguest_user.c b/drivers/lguest/lguest_user.c index c4c6113..30c6068 100644 --- a/drivers/lguest/lguest_user.c +++ b/drivers/lguest/lguest_user.c @@ -339,6 +339,13 @@ static ssize_t write(struct file *file, const char __user *in, } } +static int open(struct inode *inode, struct file *file) +{ + file->private_data = NULL; + + return 0; +} + /*L:060 * The final piece of interface code is the close() routine. It reverses * everything done in initialize(). This is usually called because the @@ -409,6 +416,7 @@ static int close(struct inode *inode, struct file *file) */ static const struct file_operations lguest_fops = { .owner = THIS_MODULE, + .open = open, .release = close, .write = write, .read = read, -- 2.1.4