From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753028AbbCWNA5 (ORCPT ); Mon, 23 Mar 2015 09:00:57 -0400 Received: from mx02.posteo.de ([89.146.194.165]:40175 "EHLO mx02.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752527AbbCWNAw (ORCPT ); Mon, 23 Mar 2015 09:00:52 -0400 From: Martin Kepplinger To: tomvanbraeckel@gmail.com Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, arnd@arndb.de Subject: always assign miscdevice to file->private_data Date: Mon, 23 Mar 2015 13:59:45 +0100 Message-Id: <1427115589-469-1-git-send-email-martink@posteo.de> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I've been trying this a few months ago, ( https://lkml.org/lkml/2014/10/8/98 ) in a very bad attempt that (thankfully) failed. I'm happy to see you trying this now and got the change in drivers/fuse merged now. I've been running a kernel with this change for quite some time, it's obviously fine. I also only found the btrfs ioctl miscdevice as a main user that has to change, and the lguest driver (I sent off the lguest patch to check if this is correct.) I append the additional changes I have applied locally (to the fuse change) for you. Feel free to use, test, use my signed-off-by (if you have exactly these changes) or send them off, however you want. Please be careful and double check to have all necessary changes merged before doing the change in misc_open(). Also, try to find drivers that assign or use struct miscdevice themselves. Those can be simplified. And of course drivers that basically do nothing in open(), just to have the link in private_data. Thanks for the work!