From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752176AbbCXBBq (ORCPT ); Mon, 23 Mar 2015 21:01:46 -0400 Received: from smtprelay0006.hostedemail.com ([216.40.44.6]:49602 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751980AbbCXBBn (ORCPT ); Mon, 23 Mar 2015 21:01:43 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:2894:3138:3139:3140:3141:3142:3352:3865:3866:3867:3870:3872:4321:5007:6261:7903:10004:10400:10848:11026:11232:11473:11658:11914:12043:12048:12438:12517:12519:12555:13069:13311:13357:14096:14097:14394:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: girl28_82c18e1707a1b X-Filterd-Recvd-Size: 1734 Message-ID: <1427158895.16851.70.camel@perches.com> Subject: [PATCH] selinuxfs: Fix sel_write_enforce broken return value From: Joe Perches To: Paul Moore , Stephen Smalley , Eric Paris , James Morris , "Serge E. Hallyn" , selinux@tycho.nsa.gov Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 23 Mar 2015 18:01:35 -0700 Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return a negative error value like the rest of the entries in this function. Signed-off-by: Joe Perches --- Maybe this should be stable, it goes back to commit b77a493b1dc8 ("SELinux: standardize return code handling in selinuxfs.c") back in Nov 2010, but it's guarded by a #ifdef CONFIG_SECURITY_SELINUX_DEVELOP so it probably doesn't matter much. security/selinux/selinuxfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c index 1684bcc..5fde343 100644 --- a/security/selinux/selinuxfs.c +++ b/security/selinux/selinuxfs.c @@ -152,7 +152,7 @@ static ssize_t sel_write_enforce(struct file *file, const char __user *buf, goto out; /* No partial writes. */ - length = EINVAL; + length = -EINVAL; if (*ppos != 0) goto out;