From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Benjamin Romer <benjamin.romer@unisys.com>,
David Kershner <david.kershner@unisys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: sparmaintainer@unisys.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH v5 5/5] staging: unisys: remove comparison
Date: Tue, 24 Mar 2015 20:47:30 +0530 [thread overview]
Message-ID: <1427210250-30427-5-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1427210250-30427-1-git-send-email-sudipm.mukherjee@gmail.com>
the comparison is always true as the dev_t has been initialized in the
init function and we are sending that initialized dev_t to the
cleanup().
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
v5: reordered the patch series
v4: messed up the subject in v3
v3: broke the previous patch in series
drivers/staging/unisys/visorchipset/file.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/file.c b/drivers/staging/unisys/visorchipset/file.c
index 890869a..39b19af 100644
--- a/drivers/staging/unisys/visorchipset/file.c
+++ b/drivers/staging/unisys/visorchipset/file.c
@@ -76,9 +76,7 @@ visorchipset_file_cleanup(dev_t major_dev)
if (file_cdev.ops != NULL)
cdev_del(&file_cdev);
file_cdev.ops = NULL;
- if (MAJOR(major_dev) >= 0) {
- unregister_chrdev_region(major_dev, 1);
- }
+ unregister_chrdev_region(major_dev, 1);
}
static int
--
1.8.1.2
next prev parent reply other threads:[~2015-03-24 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 15:17 [PATCH v5 1/5] staging: unisys: remove redundant variable Sudip Mukherjee
2015-03-24 15:17 ` [PATCH v5 2/5] staging: unisys: use local variable Sudip Mukherjee
2015-03-24 15:17 ` [PATCH v5 3/5] staging: unisys: use local variable in cleanup Sudip Mukherjee
2015-03-24 15:17 ` [PATCH v5 4/5] staging: unisys: remove global dev_t Sudip Mukherjee
2015-03-24 15:17 ` Sudip Mukherjee [this message]
2015-03-24 15:27 ` [PATCH v5 1/5] staging: unisys: remove redundant variable Dan Carpenter
2015-03-26 12:01 ` Greg Kroah-Hartman
2015-03-26 13:47 ` Ben Romer
2015-03-26 17:13 ` Ben Romer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427210250-30427-5-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=benjamin.romer@unisys.com \
--cc=dan.carpenter@oracle.com \
--cc=david.kershner@unisys.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparmaintainer@unisys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®