From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754231AbbCXQNu (ORCPT ); Tue, 24 Mar 2015 12:13:50 -0400 Received: from smtprelay0127.hostedemail.com ([216.40.44.127]:41069 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753008AbbCXQNq (ORCPT ); Tue, 24 Mar 2015 12:13:46 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::::,RULES_HIT:41:334:355:368:369:379:541:599:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3872:4321:5007:6120:6261:6742:7901:7903:8660:10004:10400:10848:11026:11658:11914:12295:12296:12517:12519:12533:12740:13069:13148:13230:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: spark61_5a7642fa13623 X-Filterd-Recvd-Size: 2138 Message-ID: <1427213619.5642.34.camel@perches.com> Subject: Re: [RFC PATCH 01/11] sysctl: make some functions unstatic to access by arch/lib From: Joe Perches To: Hajime Tazaki Cc: linux-arch@vger.kernel.org, Arnd Bergmann , Jonathan Corbet , Jhristoph Lameter , Jekka Enberg , Javid Rientjes , Joonsoo Kim , Jndrew Morton , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, netdev@vger.kernel.org, linux-mm@kvack.org, Jeff Dike , Richard Weinberger , Rusty Russell , Mathieu Lacage Date: Tue, 24 Mar 2015 09:13:39 -0700 In-Reply-To: <1427202642-1716-2-git-send-email-tazaki@sfc.wide.ad.jp> References: <1427202642-1716-1-git-send-email-tazaki@sfc.wide.ad.jp> <1427202642-1716-2-git-send-email-tazaki@sfc.wide.ad.jp> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-03-24 at 22:10 +0900, Hajime Tazaki wrote: > libos (arch/lib) emulates a sysctl-like interface by a function call of > userspace by enumerating sysctl tree from sysctl_table_root. It requires > to be publicly accessible to this symbol and related functions. [] > diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c [] > @@ -77,7 +77,7 @@ static int namecmp(const char *name1, int len1, const char *name2, int len2) > } > > /* Called under sysctl_lock */ > -static struct ctl_table *find_entry(struct ctl_table_header **phead, > +struct ctl_table *find_entry(struct ctl_table_header **phead, find_entry and all of the _entry functions below it are overly generic names. Maybe prefix with ctl_table_