mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <grygorii.strashko@linaro.org>
To: linux@arm.linux.org.uk, Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>
Cc: m-karicheri2@ti.com, ssantosh@kernel.org,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Grygorii Strashko <grygorii.strashko@linaro.org>
Subject: [PATCH] gpio: syscon: reduce message level when direction reg offset not in dt
Date: Tue, 24 Mar 2015 20:42:42 +0200	[thread overview]
Message-ID: <1427222562-2223-1-git-send-email-grygorii.strashko@linaro.org> (raw)
In-Reply-To: <20150324161358.GA694@kahuna>

From: Grygorii Strashko <grygorii.strashko@linaro.org>

Now GPIO syscon driver produces bunch of warnings during the
boot of Kesytone 2 SoCs:
 gpio-syscon soc:keystone_dsp_gpio@02620240: can't read the dir register offset!
 gpio-syscon soc:keystone_dsp_gpio@2620244: can't read the dir register offset!

This message unintentionally was added using dev_err(), but its
actual log level is debug, because third cell of "ti,syscon-dev" is
optional.

Hence change it to dev_dbg() as it should be.

This patch fixes commit:
 5a3e3f8 ("gpio: syscon: retriave syscon node and regs offsets from dt")

Reported-by: Russell King <linux@arm.linux.org.uk>
Signed-off-by: Grygorii Strashko <grygorii.strashko@linaro.org>
---
 drivers/gpio/gpio-syscon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c
index 257e298..045a952 100644
--- a/drivers/gpio/gpio-syscon.c
+++ b/drivers/gpio/gpio-syscon.c
@@ -219,7 +219,7 @@ static int syscon_gpio_probe(struct platform_device *pdev)
 		ret = of_property_read_u32_index(np, "gpio,syscon-dev", 2,
 						 &priv->dir_reg_offset);
 		if (ret)
-			dev_err(dev, "can't read the dir register offset!\n");
+			dev_dbg(dev, "can't read the dir register offset!\n");
 
 		priv->dir_reg_offset <<= 3;
 	}
-- 
1.9.1


       reply	other threads:[~2015-03-24 18:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150324004537.GA24816@verge.net.au>
     [not found] ` <CAKv+Gu-0jPk=KQ4gY32ELc+BVbe=1QdcrwQ+Pb=RkdwO9K3Vkw@mail.gmail.com>
     [not found]   ` <20150324161358.GA694@kahuna>
2015-03-24 18:42     ` grygorii.strashko [this message]
2015-03-24 20:00       ` Murali Karicheri
2015-03-24 20:52       ` santosh shilimkar
2015-03-27 10:18       ` Linus Walleij
     [not found]     ` <20150326003939.GA25368@verge.net.au>
     [not found]       ` <20150326133631.GB2805@arm.com>
     [not found]         ` <CANMBJr68dsbYvvHUzy6U4m4fEM6nq8dVHBH4kLQ=0c4QNOhLPQ@mail.gmail.com>
     [not found]           ` <20150327002554.GA5527@verge.net.au>
     [not found]             ` <20150327100612.GB1562@arm.com>
     [not found]               ` <7hbnj99epe.fsf@deeprootsystems.com>
     [not found]                 ` <CAKv+Gu_ZHZFm-1eXn+r7fkEHOxqSmj+Q+Mmy7k6LK531vSfAjQ@mail.gmail.com>
     [not found]                   ` <7h8uec95t2.fsf@deeprootsystems.com>
2015-04-01  9:37                     ` [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3 (was: Re: Possible regression in gcc 4.7.3 next-20150323 due to "ARM, arm64: kvm: get rid of the bounce page") Geert Uytterhoeven
2015-04-01  9:47                       ` [PATCH] mm/migrate: Mark unmap_and_move() "noinline" to avoid ICE in gcc 4.7.3 Marc Zyngier
2015-04-01 19:40                         ` Andrew Morton
2015-04-01 21:54                           ` Kevin Hilman
2015-04-01 21:59                             ` Russell King - ARM Linux
2015-04-02  7:17                               ` Geert Uytterhoeven
2015-04-02 19:12                             ` Lina Iyer
2015-04-02 21:12                               ` Kevin Hilman
2015-04-02 21:53                                 ` Lina Iyer
2015-04-07 17:57                             ` Kevin Hilman
2015-04-07 20:17                               ` Andrew Morton
2015-04-07 22:41                                 ` Kevin Hilman
2015-04-07 22:53                                   ` Andrew Morton
2015-04-07 23:27                                     ` Kevin Hilman
2015-04-07 23:36                                       ` Andrew Morton
2015-04-08  0:15                                         ` Kevin Hilman
2015-04-01 19:27                       ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427222562-2223-1-git-send-email-grygorii.strashko@linaro.org \
    --to=grygorii.strashko@linaro.org \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=m-karicheri2@ti.com \
    --cc=ssantosh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®