From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752846AbbCXXLQ (ORCPT ); Tue, 24 Mar 2015 19:11:16 -0400 Received: from mail-yh0-f67.google.com ([209.85.213.67]:34994 "EHLO mail-yh0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752190AbbCXXLO (ORCPT ); Tue, 24 Mar 2015 19:11:14 -0400 From: Sanidhya Kashyap To: tigran@aivazian.fsnet.co.uk, linux-kernel@vger.kernel.org Cc: taesoo@gatech.edu, changwoo@gatech.edu, sanidhya@gatech.edu, blee@gatech.edu, csong84@gatech.edu, Sanidhya Kashyap Subject: [PATCH] bfs: correct return values Date: Tue, 24 Mar 2015 19:10:57 -0400 Message-Id: <1427238657-9740-1-git-send-email-sanidhya.gatech@gmail.com> X-Mailer: git-send-email 2.1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In case of no memory allocation, the return should be ENOMEM instead of ENOSPC. Well, for the other case, in which the buffer head is not allocated, in that case -EIO should be returned. Signed-off-by: Sanidhya Kashyap --- fs/bfs/dir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c index 08063ae..7a818277 100644 --- a/fs/bfs/dir.c +++ b/fs/bfs/dir.c @@ -86,7 +86,7 @@ static int bfs_create(struct inode *dir, struct dentry *dentry, umode_t mode, inode = new_inode(s); if (!inode) - return -ENOSPC; + return -ENOMEM; mutex_lock(&info->bfs_lock); ino = find_first_zero_bit(info->si_imap, info->si_lasti + 1); if (ino > info->si_lasti) { @@ -293,7 +293,7 @@ static int bfs_add_entry(struct inode *dir, const unsigned char *name, for (block = sblock; block <= eblock; block++) { bh = sb_bread(dir->i_sb, block); if (!bh) - return -ENOSPC; + return -EIO; for (off = 0; off < BFS_BSIZE; off += BFS_DIRENT_SIZE) { de = (struct bfs_dirent *)(bh->b_data + off); if (!de->ino) { -- 2.1.0