From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752462AbbCYAfE (ORCPT ); Tue, 24 Mar 2015 20:35:04 -0400 Received: from smtprelay0042.hostedemail.com ([216.40.44.42]:45372 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751803AbbCYAfB (ORCPT ); Tue, 24 Mar 2015 20:35:01 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:967:968:973:982:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2525:2560:2563:2612:2682:2685:2689:2693:2828:2859:2895:2933:2937:2939:2942:2945:2947:2951:2954:2975:3000:3022:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6261:7550:7903:8603:8985:9025:9388:10004:10400:10848:11232:11256:11257:11658:11914:12043:12050:12296:12517:12519:12682:12740:13069:13161:13229:13311:13357:14106:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: skate99_65b5fca658c32 X-Filterd-Recvd-Size: 1659 Message-ID: <1427243696.12126.24.camel@perches.com> Subject: Re: [PATCH] staging: rtl8723au: Update RT_TRACE macro and uses From: Joe Perches To: Jes Sorensen Cc: Larry Finger , Greg Kroah-Hartman , linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, LKML Date: Tue, 24 Mar 2015 17:34:56 -0700 In-Reply-To: References: <1427220609.5642.39.camel@perches.com> <1427238404.12126.17.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-03-24 at 20:28 -0400, Jes Sorensen wrote: > Joe Perches writes: > > Create an rt_trace function using %pV to reduce overall code size. > > Update the macro uses to remove unnecessary and now harmful parentheses. [] > This could be further improved by fixing up all the places where the > function name is hard coded into the print statement, instead of using > __func__. In particular as a lot of it is carried over from old code > and has been renamed since. There's a cocci script for that. http://cocci.systeme.lip6.narkive.com/nKXf6Bmy/finding-embedded-function-names I expect someone will run it one day on staging.