mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sanidhya Kashyap <sanidhya.gatech@gmail.com>
To: phillip@squashfs.org.uk, linux-kernel@vger.kernel.org
Cc: taesoo@gatech.edu, changwoo@gatech.edu, sanidhya@gatech.edu,
	blee@gatech.edu, csong84@gatech.edu,
	Sanidhya Kashyap <sanidhya.gatech@gmail.com>
Subject: [PATCH] squashfs: return correct error value
Date: Wed, 25 Mar 2015 01:49:09 -0400	[thread overview]
Message-ID: <1427262549-4961-1-git-send-email-sanidhya.gatech@gmail.com> (raw)

In the squashfs_symlink_readpage(), the return value should be -EIO
instead of 0 when the code fails in obtaining the information about
the symlink metadata.

Signed-off-by: Sanidhya Kashyap <sanidhya.gatech@gmail.com>
---
 fs/squashfs/symlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/squashfs/symlink.c b/fs/squashfs/symlink.c
index 12806df..791ab36 100644
--- a/fs/squashfs/symlink.c
+++ b/fs/squashfs/symlink.c
@@ -109,7 +109,7 @@ static int squashfs_symlink_readpage(struct file *file, struct page *page)
 error_out:
 	SetPageError(page);
 	unlock_page(page);
-	return 0;
+	return -EIO;
 }
 
 
-- 
2.1.0


                 reply	other threads:[~2015-03-25  6:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427262549-4961-1-git-send-email-sanidhya.gatech@gmail.com \
    --to=sanidhya.gatech@gmail.com \
    --cc=blee@gatech.edu \
    --cc=changwoo@gatech.edu \
    --cc=csong84@gatech.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phillip@squashfs.org.uk \
    --cc=sanidhya@gatech.edu \
    --cc=taesoo@gatech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome