From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752536AbbCYJY4 (ORCPT ); Wed, 25 Mar 2015 05:24:56 -0400 Received: from ozlabs.org ([103.22.144.67]:55128 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751837AbbCYJYw (ORCPT ); Wed, 25 Mar 2015 05:24:52 -0400 Message-ID: <1427275489.31588.1.camel@ellerman.id.au> Subject: Re: [PATCH 5/6] mm/gup: Replace ACCESS_ONCE with READ_ONCE for STRICT_MM_TYPECHECKS From: Michael Ellerman To: Christian Borntraeger Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, aneesh.kumar@in.ibm.com, akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, aarcange@redhat.com, steve.capper@linaro.org, linux-mm@kvack.org, Jason Low , Linus Torvalds Date: Wed, 25 Mar 2015 20:24:49 +1100 In-Reply-To: <55127D65.7060605@de.ibm.com> References: <1427274719-25890-1-git-send-email-mpe@ellerman.id.au> <1427274719-25890-5-git-send-email-mpe@ellerman.id.au> <55127D65.7060605@de.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-03-25 at 10:18 +0100, Christian Borntraeger wrote: > Am 25.03.2015 um 10:11 schrieb Michael Ellerman: > > If STRICT_MM_TYPECHECKS is enabled the generic gup code fails to build > > because we are using ACCESS_ONCE on non-scalar types. > > > > Convert all uses to READ_ONCE. > > There is a similar patch from Jason Low in Andrews patch. Ah sorry, I didn't think to check. > If that happens in 4.0-rc, we probably want to merge this before 4.0. My series can wait, it's not urgent. So I'll plan to merge mine once Andrew's tree has gone into Linus' tree for 4.1. cheers