From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752624AbbCYUjP (ORCPT ); Wed, 25 Mar 2015 16:39:15 -0400 Received: from lb1-smtp-cloud2.xs4all.net ([194.109.24.21]:44131 "EHLO lb1-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751212AbbCYUjM (ORCPT ); Wed, 25 Mar 2015 16:39:12 -0400 Message-ID: <1427315945.10958.48.camel@x220> Subject: Re: [PATCH 1/3] mtd: nand: Add on-die ECC support From: Paul Bolle To: Richard Weinberger Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, dwmw2@infradead.org, computersforpeace@gmail.com Date: Wed, 25 Mar 2015 21:39:05 +0100 In-Reply-To: <1427292151-3835-2-git-send-email-richard@nod.at> References: <1427292151-3835-1-git-send-email-richard@nod.at> <1427292151-3835-2-git-send-email-richard@nod.at> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Probably not really the feedback you're hoping for at this moment, this being an RFC, but I spotted two nits anyway. On Wed, 2015-03-25 at 15:02 +0100, Richard Weinberger wrote: > --- /dev/null > +++ b/drivers/mtd/nand/nand_ondie.c This file makes git am whine: "new blank line at EOF". > +#include > +#include > +#include Is this include needed? The code can only be built in. This files also builds silently without that include. I used the rather hacky make EXTRA_CFLAGS="-DCONFIG_MTD_NAND_ECC_ON_DIE" drivers/mtd/nand/nand_ondie.o to test the build. > +#include > +#include > +#include > +#include > +#include Paul Bolle