From: Namhyung Kim <namhyung@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
Minchan Kim <minchan@kernel.org>
Subject: [PATCH] tracing: Increase stack skip on event trigger
Date: Thu, 26 Mar 2015 09:39:23 +0900 [thread overview]
Message-ID: <1427330363-17733-1-git-send-email-namhyung@kernel.org> (raw)
When 'stacktrace' trigger is used for event tracing, it should skip 4
functions instead of 3. Otherwise it'll contain ftrace_raw_event_XXX
like below:
# echo stacktrace > events/sched/sched_switch/trigger
# tail trace
=> rcu_gp_kthread
=> kthread
=> ret_from_fork
ksoftirqd/0-3 [000] d..3 53.343993: <stack trace>
=> ftrace_raw_event_sched_switch
=> __schedule
=> schedule
=> smpboot_thread_fn
=> kthread
=> ret_from_fork
Reported-by: Minchan Kim <minchan@kernel.org>
Cc: Tom Zanussi <tom.zanussi@linux.intel.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
kernel/trace/trace_events_trigger.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/trace_events_trigger.c b/kernel/trace/trace_events_trigger.c
index 8712df9decb4..c58fbdd3053e 100644
--- a/kernel/trace/trace_events_trigger.c
+++ b/kernel/trace/trace_events_trigger.c
@@ -965,12 +965,13 @@ static __init int register_trigger_snapshot_cmd(void) { return 0; }
#ifdef CONFIG_STACKTRACE
/*
- * Skip 3:
+ * Skip 4:
* stacktrace_trigger()
* event_triggers_post_call()
+ * ftrace_event_buffer_commit()
* ftrace_raw_event_xxx()
*/
-#define STACK_SKIP 3
+#define STACK_SKIP 4
static void
stacktrace_trigger(struct event_trigger_data *data)
--
2.3.3
next reply other threads:[~2015-03-26 0:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 0:39 Namhyung Kim [this message]
2015-04-13 22:06 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427330363-17733-1-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®