From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753024AbbCZO52 (ORCPT ); Thu, 26 Mar 2015 10:57:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49283 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752348AbbCZO50 (ORCPT ); Thu, 26 Mar 2015 10:57:26 -0400 Message-ID: <1427381842.9430.46.camel@deneb.redhat.com> Subject: Re: [PATCH] c6x: include: asm: dma-mapping: Add dummy dma_sync_single_range_for_device From: Mark Salter To: Chen Gang Cc: a-jacquiot@ti.com, linux-c6x-dev@linux-c6x.org, "linux-kernel@vger.kernel.org" Date: Thu, 26 Mar 2015 10:57:22 -0400 In-Reply-To: References: Organization: Red Hat, Inc Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-03-04 at 11:09 +0800, Chen Gang wrote: > c6x does not implement get_dma_ops() for dma-mapping-common.h. And in > dma-mapping-common.h, dma_sync_single_range_for_device() may be dummy. > So c6x can just define a dummy function for allmodconfig building. > > CC [M] drivers/net/ethernet/micrel/ks8851.o > drivers/net/ethernet/micrel/ks8842.c: In function 'ks8842_tx_frame_dma': > drivers/net/ethernet/micrel/ks8842.c:453:2: error: implicit declaration of function 'dma_sync_single_range_for_device' [-Werror=implicit-function-declaration] > dma_sync_single_range_for_device(adapter->dev, > ^ > > Signed-off-by: Chen Gang > --- Thanks! I added this to the c6x tree for next merge window. > arch/c6x/include/asm/dma-mapping.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/c6x/include/asm/dma-mapping.h b/arch/c6x/include/asm/dma-mapping.h > index 88bd0d8..bbd7774 100644 > --- a/arch/c6x/include/asm/dma-mapping.h > +++ b/arch/c6x/include/asm/dma-mapping.h > @@ -17,6 +17,14 @@ > > #define dma_supported(d, m) 1 > > +static inline void dma_sync_single_range_for_device(struct device *dev, > + dma_addr_t addr, > + unsigned long offset, > + size_t size, > + enum dma_data_direction dir) > +{ > +} > + > static inline int dma_set_mask(struct device *dev, u64 dma_mask) > { > if (!dev->dma_mask || !dma_supported(dev, dma_mask))