From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753222AbbCZO6B (ORCPT <rfc822;w@1wt.eu>);
	Thu, 26 Mar 2015 10:58:01 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42530 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752984AbbCZO57 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 26 Mar 2015 10:57:59 -0400
Message-ID: <1427381876.9430.48.camel@deneb.redhat.com>
Subject: Re: [PATCH] c6x: kernel: setup: Add screen_info global variable
From: Mark Salter <msalter@redhat.com>
To: Chen Gang <xili_gchen_5257@hotmail.com>
Cc: a-jacquiot@ti.com, linux-c6x-dev@linux-c6x.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date: Thu, 26 Mar 2015 10:57:56 -0400
In-Reply-To: <BLU436-SMTP246AEBA8CA0F91927D48F0DB91E0@phx.gbl>
References: <BLU436-SMTP246AEBA8CA0F91927D48F0DB91E0@phx.gbl>
Organization: Red Hat, Inc
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2015-03-04 at 14:12 +0800, Chen Gang wrote:
> Or can not pass building with allmodconfig:
> 
>     LD      init/built-in.o
>   drivers/built-in.o: In function `vgacon_switch':
>   vgacon.c:(.text+0x47f8): undefined reference to `screen_info'
>   vgacon.c:(.text+0x4810): undefined reference to `screen_info'
>   drivers/built-in.o: In function `vgacon_resize':
>   vgacon.c:(.text+0x4ac8): undefined reference to `screen_info'
>   vgacon.c:(.text+0x4acc): undefined reference to `screen_info'
>   drivers/built-in.o: In function `vgacon_save_screen':
>   vgacon.c:(.text+0x4cc8): undefined reference to `screen_info'
>   drivers/built-in.o:vgacon.c:(.text+0x4cd0): more undefined references to `screen_info' follow
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---

Thanks! I added this to the c6x tree for next merge window.

>  arch/c6x/kernel/setup.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/c6x/kernel/setup.c b/arch/c6x/kernel/setup.c
> index 1d9f399..165bbd9 100644
> --- a/arch/c6x/kernel/setup.c
> +++ b/arch/c6x/kernel/setup.c
> @@ -27,6 +27,7 @@
>  #include <linux/fs.h>
>  #include <linux/of.h>
>  #include <linux/console.h>
> +#include <linux/screen_info.h>
>  
>  #include <asm/sections.h>
>  #include <asm/div64.h>
> @@ -38,6 +39,8 @@
>  
>  static const char *c6x_soc_name;
>  
> +struct screen_info screen_info;
> +
>  int c6x_num_cores;
>  EXPORT_SYMBOL_GPL(c6x_num_cores);
>