From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752886AbbCZVFw (ORCPT ); Thu, 26 Mar 2015 17:05:52 -0400 Received: from mga01.intel.com ([192.55.52.88]:8806 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751644AbbCZVFv (ORCPT ); Thu, 26 Mar 2015 17:05:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,474,1422950400"; d="scan'208";a="686240695" Message-ID: <1427403945.3324.44.camel@ideak-mobl> Subject: Re: Re: [PATCH v4 3/3] vt: fix console lock vs. kernfs s_active lock order From: Imre Deak Reply-To: imre.deak@intel.com To: Greg Kroah-Hartman Cc: Jesse Barnes , Daniel Vetter , Peter Hurley , Jiri Slaby , Linux Kernel Mailing List Date: Thu, 26 Mar 2015 23:05:45 +0200 In-Reply-To: <20150326210141.GD5481@kroah.com> References: <1418681761-3709-3-git-send-email-imre.deak@intel.com> <20141216075300.GI2711@phenom.ffwll.local> <1418725405.3185.31.camel@ideak-mobl> <54902AA1.7080301@hurleysoftware.com> <1418740692.7338.33.camel@intelbox> <5490491E.70102@hurleysoftware.com> <1418746939.7338.56.camel@intelbox> <549068A4.3020702@hurleysoftware.com> <55146509.4020809@virtuousgeek.org> <20150326210141.GD5481@kroah.com> Organization: Intel Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-03-26 at 22:01 +0100, Greg Kroah-Hartman wrote: > On Thu, Mar 26, 2015 at 12:59:05PM -0700, Jesse Barnes wrote: > > On 12/16/2014 09:42 AM, Daniel Vetter wrote: > > > On Tue, Dec 16, 2014 at 6:15 PM, Peter Hurley wrote: > > >> On 12/16/2014 11:22 AM, Imre Deak wrote: > > >>> On Tue, 2014-12-16 at 10:00 -0500, Peter Hurley wrote: > > >>>> Fine. Just another expedient fix piled on top of other expedient fixes > > >>>> that go back past 3.9 with no end in sight. > > >>> > > >>> I'm also happy to look into narrowing down the scope of console_lock in > > >>> fbdev/fbcon as was suggested. But doing that as a follow-up to this > > >>> change still makes sense to me since it will take more time and have the > > >>> risk of regressions that are not related to what this change fixes. > > >> > > >> I apologize for my tone. I'm not blaming you for the current situation, > > >> nor is it your responsibility to go fix vt/fbcon/fbdev driver stack > > >> inversion. I'm just trying to bring some awareness of the larger scope, > > >> so that collectively we take action and resolve the underlying problems. > > > > > > Yeah I guess I should tune down my NACK to a Grumpy-if-merged-by too. > > > We have a lot of nonoptimal solutions at hand here :( > > > > So where does that leave us with this fix? Should we wait for someone > > to come along and do all the rework? Imre said he'd be willing to do > > it, but still feels this fix makes sense > > > > Or we could just abandon the fb layer altogether (my preference). In > > that case fixing this is fine, since we'll be able to ignore it for > > configs that switch over to using !fbdev and kmscon. > > I think I already merged the patches a while ago :) Yes, but only the first two patches. This third one is not merged AFAICS. --Imre