From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932167AbbC0JHN (ORCPT ); Fri, 27 Mar 2015 05:07:13 -0400 Received: from mga09.intel.com ([134.134.136.24]:6417 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752724AbbC0JHI (ORCPT ); Fri, 27 Mar 2015 05:07:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,477,1422950400"; d="scan'208";a="705004313" From: Wanpeng Li To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Alex Williamson , Paolo Bonzini , Wanpeng Li Subject: [PATCH] kvm: vfio: fix fail to set error notification Date: Fri, 27 Mar 2015 16:48:43 +0800 Message-Id: <1427446123-11203-1-git-send-email-wanpeng.li@linux.intel.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After commit 6140a8f56238 ("vfio-pci: Add device request interface") merged, there is error dump when run guest as below: qemu-system-x86_64 -enable-kvm -m 2G -smp 2 -net none /root/cathy/rhel6u5.qcow -device vfio-pci,host=03:10.5 qemu-system-x86_64: -device vfio-pci,host=03:10.5: vfio: Failed to set up error notification This is caused by missing one break, this patch fix it. Reported-and-tested-by: Liu Rongrong Signed-off-by: Wanpeng Li --- drivers/vfio/pci/vfio_pci_intrs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c index f88bfdf..d1b6845 100644 --- a/drivers/vfio/pci/vfio_pci_intrs.c +++ b/drivers/vfio/pci/vfio_pci_intrs.c @@ -868,6 +868,7 @@ int vfio_pci_set_irqs_ioctl(struct vfio_pci_device *vdev, uint32_t flags, func = vfio_pci_set_err_trigger; break; } + break; case VFIO_PCI_REQ_IRQ_INDEX: switch (flags & VFIO_IRQ_SET_ACTION_TYPE_MASK) { case VFIO_IRQ_SET_ACTION_TRIGGER: -- 1.9.1