From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752720AbbC0FSH (ORCPT ); Fri, 27 Mar 2015 01:18:07 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:47235 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751046AbbC0FSD (ORCPT ); Fri, 27 Mar 2015 01:18:03 -0400 From: Tao Chen To: , CC: , , , , Subject: [PATCH v2] xen-blkback: enlarge the array size of blkback name Date: Fri, 27 Mar 2015 13:15:54 +0000 Message-ID: <1427462154-71429-1-git-send-email-boby.chen@huawei.com> X-Mailer: git-send-email 1.8.5 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.101.253] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The blkback name is like blkback.domid.xvd[a-z], if domid has four digits (means larger than 1000), then the backmost xvd wouldn't be fully shown. Define a BLKBACK_NAME_LEN macro to be 20, enlarge the array size of blkback name, so it will be fully shown in any case. Signed-off-by: Tao Chen --- v2: - Change the value of BLKBACK_NAME_LEN macro from (TASK_COMM_LEN * 2) to 20. Because 20 is already safe for the length of blkback name. --- drivers/block/xen-blkback/xenbus.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c index e3afe97..b33083e 100644 --- a/drivers/block/xen-blkback/xenbus.c +++ b/drivers/block/xen-blkback/xenbus.c @@ -21,6 +21,9 @@ #include #include "common.h" +/* Enlarge the array size in order to fully show blkback name. */ +#define BLKBACK_NAME_LEN (20) + struct backend_info { struct xenbus_device *dev; struct xen_blkif *blkif; @@ -70,7 +73,7 @@ static int blkback_name(struct xen_blkif *blkif, char *buf) else devname = devpath; - snprintf(buf, TASK_COMM_LEN, "blkback.%d.%s", blkif->domid, devname); + snprintf(buf, BLKBACK_NAME_LEN, "blkback.%d.%s", blkif->domid, devname); kfree(devpath); return 0; @@ -79,7 +82,7 @@ static int blkback_name(struct xen_blkif *blkif, char *buf) static void xen_update_blkif_status(struct xen_blkif *blkif) { int err; - char name[TASK_COMM_LEN]; + char name[BLKBACK_NAME_LEN]; /* Not ready to connect? */ if (!blkif->irq || !blkif->vbd.bdev) -- 1.8.5