From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752665AbbC0NWY (ORCPT ); Fri, 27 Mar 2015 09:22:24 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58012 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752469AbbC0NWX (ORCPT ); Fri, 27 Mar 2015 09:22:23 -0400 Subject: Re: [PATCH] firmware: dmi_scan: Prevent dmi_num integer overflow From: Jean Delvare To: Matt Fleming Cc: LKML , Matt Fleming , Ard Biesheuvel , Ivan Khoronzhuk In-Reply-To: <20150327121243.GA5801@codeblueprint.co.uk> References: <20150320095947.644f9c67@endymion.delvare> <20150326130651.GC6525@codeblueprint.co.uk> <1427375705.4261.2.camel@chaos.site> <20150326144717.GD6525@codeblueprint.co.uk> <1427383313.4261.7.camel@chaos.site> <20150327121243.GA5801@codeblueprint.co.uk> Content-Type: text/plain; charset="UTF-8" Organization: Suse Linux Date: Fri, 27 Mar 2015 14:22:15 +0100 Message-ID: <1427462535.26270.4.camel@chaos.site> Mime-Version: 1.0 X-Mailer: Evolution 2.28.2 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matt, Le Friday 27 March 2015 à 12:12 +0000, Matt Fleming a écrit : > On Thu, 26 Mar, at 04:21:53PM, Jean Delvare wrote: > > Le Thursday 26 March 2015 à 14:47 +0000, Matt Fleming a écrit : > > > On Thu, 26 Mar, at 02:15:05PM, Jean Delvare wrote: > > > > > > > > I don't actually have a tree, so feel free to pick it. > > > > > > OK will do, but this is a regression fix for a potential bug introduced > > > in commit 6d9ff4733172 ("firmware: dmi_scan: Fix dmi_len type"), right? > > > > Not really. I'd rather say it complements commit 6d9ff4733172. The > > actual bugs were introduced in commit fc43026278b2. But you can't really > > call it a regression as SMBIOS 3.0 entry points were not supported at > > all before that commit. > > OK, thanks for clarifying. > > > Still a reference to commit fc43026278b2 would certainly be appropriate, > > as anyone backporting that commit will also want to pick the two > > aforementioned fix-ups (plus ce204e9a4bd8 for that matter.) > > commit ce204e9a4bd8 and 6d9ff4733172 are already tagged for stable, so > we should be good there. > > This is what I've got queued up to send to tip today. Feel free to send > me another version today if you want to word things differently. Looks good, thanks for taking care of it. -- Jean Delvare SUSE L3 Support