From: Hanjun Guo <hanjun.guo@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Sudeep Holla <Sudeep.Holla@arm.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linaro-acpi@lists.linaro.org, Hanjun Guo <hanjun.guo@linaro.org>
Subject: [PATCH 4/7] Xen / ACPI / processor: use invalid_logical_cpuid()
Date: Fri, 27 Mar 2015 22:02:25 +0800 [thread overview]
Message-ID: <1427464948-14564-5-git-send-email-hanjun.guo@linaro.org> (raw)
In-Reply-To: <1427464948-14564-1-git-send-email-hanjun.guo@linaro.org>
Use invalid_logical_cpuid(pr->id) instead of direct comparison
of -1.
Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
CC: Boris Ostrovsky <boris.ostrovsky@oracle.com>
CC: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
drivers/xen/xen-acpi-cpuhotplug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/xen/xen-acpi-cpuhotplug.c b/drivers/xen/xen-acpi-cpuhotplug.c
index 3e62ee4..5a62aa0 100644
--- a/drivers/xen/xen-acpi-cpuhotplug.c
+++ b/drivers/xen/xen-acpi-cpuhotplug.c
@@ -77,7 +77,7 @@ static int xen_acpi_processor_enable(struct acpi_device *device)
pr->id = xen_pcpu_id(pr->acpi_id);
- if ((int)pr->id < 0)
+ if (invalid_logical_cpuid(pr->id))
/* This cpu is not presented at hypervisor, try to hotadd it */
if (ACPI_FAILURE(xen_acpi_cpu_hotadd(pr))) {
pr_err(PREFIX "Hotadd CPU (acpi_id = %d) failed.\n",
@@ -226,7 +226,7 @@ static acpi_status xen_acpi_cpu_hotadd(struct acpi_processor *pr)
return AE_ERROR;
pr->id = xen_hotadd_cpu(pr);
- if ((int)pr->id < 0)
+ if (invalid_logical_cpuid(pr->id))
return AE_ERROR;
/*
--
1.9.1
next prev parent reply other threads:[~2015-03-27 14:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 14:02 [PATCH 0/7] minor cleanups for ACPI processor driver Hanjun Guo
2015-03-27 14:02 ` [PATCH 1/7] ACPI / processor: remove cpu_index in acpi_processor_get_info() Hanjun Guo
2015-03-27 14:02 ` [PATCH 2/7] ACPI / processor: remove phys_id " Hanjun Guo
2015-03-27 14:02 ` [PATCH 3/7] ACPI / processor: Introduce invalid_logical_cpuid() Hanjun Guo
2015-03-27 14:02 ` Hanjun Guo [this message]
2015-03-27 14:02 ` [PATCH 5/7] Xen / ACPI / processor: Remove unneeded NULL check in xen_acpi_processor_enable() Hanjun Guo
2015-03-27 14:02 ` [PATCH 6/7] ACPI / processor: return specific error instead of -1 Hanjun Guo
2015-03-27 14:02 ` [PATCH 7/7] ACPI / processor: Introduce invalid_phys_cpuid() Hanjun Guo
2015-05-04 23:50 ` [PATCH 0/7] minor cleanups for ACPI processor driver Rafael J. Wysocki
2015-05-05 1:10 ` Hanjun Guo
-- strict thread matches above, loose matches on Subject: below --
2015-03-27 13:55 Hanjun Guo
2015-03-27 13:55 ` [PATCH 4/7] Xen / ACPI / processor: use invalid_logical_cpuid() Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427464948-14564-5-git-send-email-hanjun.guo@linaro.org \
--to=hanjun.guo@linaro.org \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=Sudeep.Holla@arm.com \
--cc=boris.ostrovsky@oracle.com \
--cc=catalin.marinas@arm.com \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=stefano.stabellini@eu.citrix.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®