From: "K. Y. Srinivasan" <kys@microsoft.com>
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
vkuznets@redhat.com, jasowang@redhat.com
Cc: Haiyang Zhang <haiyangz@microsoft.com>,
"K. Y. Srinivasan" <kys@microsoft.com>
Subject: [PATCH 7/7] hv_vmbus: Add gradually increased delay for retries in vmbus_post_msg()
Date: Fri, 27 Mar 2015 09:10:14 -0700 [thread overview]
Message-ID: <1427472614-32625-7-git-send-email-kys@microsoft.com> (raw)
In-Reply-To: <1427472614-32625-1-git-send-email-kys@microsoft.com>
From: Haiyang Zhang <haiyangz@microsoft.com>
Most of the retries can be done within a millisecond successfully, so we
sleep 1ms before the first retry, then gradually increase the retry
interval to 2^n with max value of 2048ms. Doing so, we will have shorter
overall delay time, because most of the cases succeed within 1-2 attempts.
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
Reviewed-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
drivers/hv/connection.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c
index 583d7d4..b27220a 100644
--- a/drivers/hv/connection.c
+++ b/drivers/hv/connection.c
@@ -422,6 +422,7 @@ int vmbus_post_msg(void *buffer, size_t buflen)
union hv_connection_id conn_id;
int ret = 0;
int retries = 0;
+ u32 msec = 1;
conn_id.asu32 = 0;
conn_id.u.id = VMBUS_MESSAGE_CONNECTION_ID;
@@ -431,7 +432,7 @@ int vmbus_post_msg(void *buffer, size_t buflen)
* insufficient resources. Retry the operation a couple of
* times before giving up.
*/
- while (retries < 10) {
+ while (retries < 20) {
ret = hv_post_message(conn_id, 1, buffer, buflen);
switch (ret) {
@@ -454,7 +455,9 @@ int vmbus_post_msg(void *buffer, size_t buflen)
}
retries++;
- msleep(1000);
+ msleep(msec);
+ if (msec < 2048)
+ msec *= 2;
}
return ret;
}
--
1.7.4.1
prev parent reply other threads:[~2015-03-27 14:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 16:09 [PATCH 0/7] Drivers: hv: Miscellaneous cleanups and bug fixes K. Y. Srinivasan
2015-03-27 16:10 ` [PATCH 1/7] hv: run non-blocking message handlers in the dispatch tasklet K. Y. Srinivasan
2015-03-27 16:10 ` [PATCH 2/7] hv: don't schedule new works in vmbus_onoffer()/vmbus_onoffer_rescind() K. Y. Srinivasan
2015-03-27 16:10 ` [PATCH 3/7] hv: remove the per-channel workqueue K. Y. Srinivasan
2015-03-27 16:10 ` [PATCH 4/7] Drivers: hv: hv_balloon: do not online pages in offline blocks K. Y. Srinivasan
2015-03-27 16:10 ` [PATCH 5/7] Drivers: hv: hv_balloon: eliminate jumps in piecewiese linear floor function K. Y. Srinivasan
2015-03-27 16:10 ` [PATCH 6/7] Drivers: hv: hv_balloon: survive ballooning request with num_pages=0 K. Y. Srinivasan
2015-03-27 16:10 ` K. Y. Srinivasan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427472614-32625-7-git-send-email-kys@microsoft.com \
--to=kys@microsoft.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome