From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753385AbbKWHVF (ORCPT ); Mon, 23 Nov 2015 02:21:05 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:45114 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751417AbbKWHVC (ORCPT ); Mon, 23 Nov 2015 02:21:02 -0500 X-AuditID: cbfee68f-f79666d0000076bb-f2-5652be5c735a Date: Mon, 23 Nov 2015 07:21:00 +0000 (GMT) From: MyungJoo Ham Subject: Re: Re: [PATCH 6/6] PM / devfreq: Set the min_freq and max_freq of devfreq device To: =?utf-8?Q?=EC=B5=9C=EC=B0=AC=EC=9A=B0?= , =?utf-8?Q?=EB=B0=95=EA=B2=BD=EB=AF=BC?= Cc: "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" Reply-to: myungjoo.ham@samsung.com MIME-version: 1.0 X-MTR: 20151123071323286@myungjoo.ham Msgkey: 20151123071323286@myungjoo.ham X-EPLocale: ko_KR.utf-8 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20151123071323286@myungjoo.ham X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general Content-type: text/plain; charset=utf-8 MIME-version: 1.0 Message-id: <1427563269.125721448263260488.JavaMail.weblogic@epmlwas06a> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrIIsWRmVeSWpSXmKPExsWyRsSkRDdmX1CYwabVuhaXd81hc2D0+LxJ LoAxissmJTUnsyy1SN8ugSvj3YV7rAU/uCpO3t7G2MB4gauLkZNDSEBdYtGSk2xdjBwcEgIm Epem5YOEJQTEJC7cWw8U5gIqWcoocWb1LLiaPT+CIOJzGCWubT7PBBJnEVCVOHekBMRkE9CT mPk5GWSMsECUxKIrFxhBykUE+hglDv+ezQ6SYBaoklh17Bc7xAlKEmv2vWIBsXkFBCVOznzC AnGDqsSkhpVMEHE1iZZpd5kg4uISF+ZeYoeweSVmtD+FqpeTmPZ1DTOELS1xftYGRphfFn9/ DBXnlzh2ewfUHAGJqWcOQtVoSZxsngAV55NYs/AtC0z9rlPLmWF23d8yF6pGQmJryxNWiF8U JaZ0P2QH+Z1ZQFNi/S59dK/wCnhIXF6/jwkUDhICUzkkepbdYJrAqDQLSd0sJKNmIYxCVrKA kWUVo2hqQXJBcVJ6kbFecWJucWleul5yfu4mRmBKOP3vWf8OxrsHrA8xCnAwKvHwauoHhQmx JpYVV+YeYjQFRtJEZinR5Hxg4skriTc0NjOyMDUxNTYytzRTEuddKPUzWEggPbEkNTs1tSC1 KL6oNCe1+BAjEwenVANje9Ze1VM/FA0mXo1Wu1WycccLjdjQNwGTVn96ozbhsP/i5iBHgQNv rb+JpU8MvXBu85f44l3mgYYrg8UvTLVPX2Zs9PedkMJ8rtVbK//lFEc5ru9++4drbjp7H1v6 tC17pmzZElpUHChZf99EgNc4g8NhgcehoIJ2/dUMRt09m2ON08+f9OdUYinOSDTUYi4qTgQA mSpQqAQDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMKsWRmVeSWpSXmKPExsVy+t/tft2YfUFhBtvWqVlc3jWHzYHR4/Mm uQDGqDSbjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKCh SgpliTmlQKGAxOJiJX07m6L80pJUhYz84hJbpWhDcyM9IwM9UyM9Q+NYK0MDAyNToJqEtIx3 F+6xFvzgqjh5extjA+MFri5GTg4hAXWJRUtOsnUxcnBICJhI7PkRBBKWEBCTuHBvPVCYC6hk DqPEtc3nmUBqWARUJc4dKQEx2QT0JGZ+TgYpFxaIklh05QIjSLmIQB+jxOHfs9lBEswCVRKr jv1ih1ilJLFm3ysWEJtXQFDi5MwnLBC7VCUmNaxkgoirSbRMu8sEEReXuDD3EjuEzSsxo/0p VL2cxLSva5ghbGmJ87M2MMLcvPj7Y6g4v8Sx2zug5ghITD1zEKpGS+Jk8wSoOJ/EmoVvWWDq d51azgyz6/6WuVA1EhJbW56wQvyiKDGl+yE7yO/MApoS63fpo3uFV8BD4vL6fUwTGGVnIUnN QtI9C6EbWckCRpZVjKKpBckFxUnpFUZ6xYm5xaV56XrJ+bmbGMEJ6NmiHYz/zlsfYhTgYFTi 4dXQDwoTYk0sK67MPcQowcGsJMJ7ZCtQiDclsbIqtSg/vqg0J7X4EKMpMMomMkuJJucDk2Ne SbyhsbGJmYmppYmFgam5kjjv7X1+YUIC6YklqdmpqQWpRTB9TBycUg2Mz32euDUWnk318+tY 5Ky2u+uXSmWHwwKJKXXvVRQuXQz7n6S2q01ExlMgImDurC+cS80W9QZbldRczws2qMtP7Jtl /iGZyzUgcM+Wl7F15m+cX3TZdaSE9Nps5j/huTvtxZJtxTvDC8qWq15dOuf0z+0yc9UeLrY5 7Cqx9DzbvIN7rvw0qXVUYinOSDTUYi4qTgQAhqhoo1YDAAA= DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tAN7L9pb010526 [] > > > > The value 0 is used for min/max_freq to declare > > that min/max_freq is deactivated. Therefore, it is not > > required to do so; they are not intended to show the hardware > > configuration as well. > > This case consider the devfreq device using OPP because devfreq_set_freq_table() > get the number of OPP entry in OPP list before setting the min_freq/max_freq. > If the devfreq device don't use the OPP entry, devfreq_set_freq_table() > will return without any operation. > > IMHO, when devfreq device uses the OPP table including the frequency, > min_freq/max_freq should show the correct value as CPUFREQ framework. > The side effect of this patch shows up when opp_disable() and opp_enable() are used. For example, 1. dev->opp_disable(2GHz); /* 2GHz is the fastest and 1.6 is the second */ 2. init devfreq of dev; /* setting max_freq @ 1.6G by this patch */ 3. dev->opp_enable(2GHz); 4. 2GHz is still not active because max_freq is now 1.6GHz. Cheers, MyungJoo. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I