From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
sakari.ailus@linux.intel.com, Bryan Wu <cooloney@gmail.com>,
Richard Purdie <rpurdie@rpsys.net>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Sakari Ailus <sakari.ailus@iki.fi>,
Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Subject: [PATCH 2/3] leds: Use log level warn instead of info when telling about a name clash
Date: Mon, 30 Mar 2015 19:46:00 +0200 [thread overview]
Message-ID: <1427737561-2424-3-git-send-email-ricardo.ribalda@gmail.com> (raw)
In-Reply-To: <1427737561-2424-1-git-send-email-ricardo.ribalda@gmail.com>
From: Sakari Ailus <sakari.ailus@iki.fi>
The LED names are expected to be unique in the system. Use KERN_WARNING log
level to notify the user about the matter.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
drivers/leds/led-class.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
index fc57d9c..82e3844 100644
--- a/drivers/leds/led-class.c
+++ b/drivers/leds/led-class.c
@@ -257,7 +257,7 @@ int led_classdev_register(struct device *parent, struct led_classdev *led_cdev)
return PTR_ERR(led_cdev->dev);
if (ret)
- dev_info(parent, "Led %s renamed to %s due to name collision",
+ dev_warn(parent, "Led %s renamed to %s due to name collision",
led_cdev->name, dev_name(led_cdev->dev));
#ifdef CONFIG_LEDS_TRIGGERS
--
2.1.4
next prev parent reply other threads:[~2015-03-30 17:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 17:45 [PATCH 0/3] Handle LEDs with the same name Ricardo Ribalda Delgado
2015-03-30 17:45 ` [PATCH 1/3] leds/led-class: " Ricardo Ribalda Delgado
2015-03-30 17:46 ` Ricardo Ribalda Delgado [this message]
2015-03-30 17:46 ` [PATCH 3/3] leds: Don't treat the LED name as a format string Ricardo Ribalda Delgado
2015-03-30 22:08 ` [PATCH 0/3] Handle LEDs with the same name Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427737561-2424-3-git-send-email-ricardo.ribalda@gmail.com \
--to=ricardo.ribalda@gmail.com \
--cc=cooloney@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=sakari.ailus@iki.fi \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®