From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752934AbbCaWZP (ORCPT ); Tue, 31 Mar 2015 18:25:15 -0400 Received: from mail-lb0-f177.google.com ([209.85.217.177]:33832 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751668AbbCaWZL (ORCPT ); Tue, 31 Mar 2015 18:25:11 -0400 From: Mateusz Kulikowski To: gregkh@linuxfoundation.org Cc: Mateusz Kulikowski , joe@perches.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 00/13] staging: rtl8192e: checkpatch.pl cleanups Date: Wed, 1 Apr 2015 00:24:25 +0200 Message-Id: <1427840678-14751-1-git-send-email-mateusz.kulikowski@gmail.com> X-Mailer: git-send-email 1.8.4.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org v2 Notes: Added 2 more patches (none affects code): #12 cleanup of comment style (Joe requested to fix one, did fix of as many as I was able to find) #13 Removed dead code (some functions/structures/defines were commented out) As for v1 review comments - I decided not to merge #10 and #11 to make bisect easier (patch that may cause regressions will be as simple as possible) Still have no proper antennas - only smoke test performed. checkpatch.pl reports long-lines on some comments, but decidet not to reformat them for now (this driver for now is full of >80 character lines, it's least of issues it has) v1 Notes: This series of patches cleans bunch of checkpatch.pl warnings. It should apply to staging-next (153fe946) and staging-testing (f8da055a). Patch 10 changes code/logic a bit (but behaviour should not change). Remaining patches are trivial. Smoke tested on rtl8192e card vs staging-next: - Module load/unload - Interface up/down For now I'm not able to do more tests as I don't have proper antennas Mateusz Kulikowski (13): staging: rtl8192e: Fix UNNECESSARY_ELSE warning staging: rtl8192e: Fix RETURN_VOID warnings staging: rtl8192e: remove unused EXPORT_SYMBOL_RSL macro staging: rtl8192e: Fix UNNECESSARY_PARENTHESES warnings staging: rtl8192e: Fix LINE_CONTINUATIONS warning staging: rtl8192e: Fix BRACES warning staging: rtl8192e: Fix DO_WHILE_MACRO_WITH_TRAILING_SEMICOLON warning staging: rtl8192e: Fix PRINTK_WITHOUT_KERN_LEVEL warnings staging: rtl8192e: Divide rtllib_rx_auth() staging: rtl8192e: Decrease nesting of rtllib_rx_auth_resp() staging: rtl8192e: Fix indentation in rtllib_rx_auth_resp() staging: rtl8192e: Comment cleanup (style/format) staging: rtl8192e: Remove dead code drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 2 +- drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.h | 30 +- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 77 +++-- .../staging/rtl8192e/rtl8192e/r8192E_firmware.c | 6 +- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 22 +- drivers/staging/rtl8192e/rtl8192e/r819xE_phyreg.h | 7 - drivers/staging/rtl8192e/rtl8192e/rtl_cam.c | 7 +- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 225 +++++++-------- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 319 ++++++++++----------- drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 9 +- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 29 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 34 ++- drivers/staging/rtl8192e/rtl819x_TSProc.c | 120 ++++---- drivers/staging/rtl8192e/rtllib.h | 109 ++++--- drivers/staging/rtl8192e/rtllib_crypt.c | 3 +- drivers/staging/rtl8192e/rtllib_crypt.h | 3 +- drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 8 +- drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 15 +- drivers/staging/rtl8192e/rtllib_crypt_wep.c | 3 +- drivers/staging/rtl8192e/rtllib_debug.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 229 +++++++-------- drivers/staging/rtl8192e/rtllib_softmac.c | 211 +++++++------- drivers/staging/rtl8192e/rtllib_tx.c | 303 +++++++++---------- drivers/staging/rtl8192e/rtllib_wx.c | 23 +- 24 files changed, 869 insertions(+), 927 deletions(-) -- 1.8.4.1