From: <yanjiang.jin@windriver.com>
To: <bruce.w.allan@intel.com>
Cc: <jeffrey.t.kirsher@intel.com>, <jesse.brandeburg@intel.com>,
<carolyn.wyborny@intel.com>, <donald.c.skidmore@intel.com>,
<gregory.v.rose@intel.com>, <matthew.vick@intel.com>,
<john.ronciak@intel.com>, <mitch.a.williams@intel.com>,
<e1000-devel@lists.sourceforge.net>, <linux.nics@intel.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<jinyanjiang@gmail.com>
Subject: [PATCH] ethernet: e1000e: define lat_ns as u64 instead of s64
Date: Fri, 3 Apr 2015 17:17:53 +0800 [thread overview]
Message-ID: <1428052673-16412-1-git-send-email-yanjiang.jin@windriver.com> (raw)
From: Yanjiang Jin <yanjiang.jin@windriver.com>
do_div() expects the type of "n" to be uint64_t, define "lat_ns" as u64 to
avoid the below warning, also update its correlative operations and data.
In file included from ./arch/powerpc/include/asm/div64.h:1:0,
from include/linux/kernel.h:124,
from include/linux/list.h:8,
from include/linux/timer.h:4,
from drivers/net/ethernet/intel/e1000e/e1000.h:29,
from drivers/net/ethernet/intel/e1000e/ich8lan.c:59:
drivers/net/ethernet/intel/e1000e/ich8lan.c: In function 'e1000_platform_pm_pch_lpt':
include/asm-generic/div64.h:43:28: warning: comparison of distinct pointer types lacks a cast [enabled by default]
(void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
^
drivers/net/ethernet/intel/e1000e/ich8lan.c:1016:4: note: in expansion of macro 'do_div'
do_div(lat_ns, speed);
Signed-off-by: Yanjiang Jin <yanjiang.jin@windriver.com>
---
drivers/net/ethernet/intel/e1000e/ich8lan.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c
index 48b74a5..baab58b 100644
--- a/drivers/net/ethernet/intel/e1000e/ich8lan.c
+++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c
@@ -982,8 +982,8 @@ static s32 e1000_platform_pm_pch_lpt(struct e1000_hw *hw, bool link)
u16 speed, duplex, scale = 0;
u16 max_snoop, max_nosnoop;
u16 max_ltr_enc; /* max LTR latency encoded */
- s64 lat_ns; /* latency (ns) */
- s64 value;
+ u64 lat_ns; /* latency (ns) */
+ u64 value;
u32 rxa;
if (!hw->adapter->max_frame_size) {
@@ -1008,8 +1008,8 @@ static s32 e1000_platform_pm_pch_lpt(struct e1000_hw *hw, bool link)
* 2^25*(2^10-1) ns. The scale is encoded as 0=2^0ns,
* 1=2^5ns, 2=2^10ns,...5=2^25ns.
*/
- lat_ns = ((s64)rxa * 1024 -
- (2 * (s64)hw->adapter->max_frame_size)) * 8 * 1000;
+ lat_ns = ((u64)rxa * 1024 -
+ (2 * (u64)hw->adapter->max_frame_size)) * 8 * 1000;
if (lat_ns < 0)
lat_ns = 0;
else
--
1.9.1
next reply other threads:[~2015-04-03 9:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 9:17 yanjiang.jin [this message]
2015-04-08 9:40 ` David Laight
2015-04-08 18:13 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428052673-16412-1-git-send-email-yanjiang.jin@windriver.com \
--to=yanjiang.jin@windriver.com \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jinyanjiang@gmail.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.nics@intel.com \
--cc=matthew.vick@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®