mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicholas Mc Guire <hofrat@osadl.org>
To: David Airlie <airlied@linux.ie>
Cc: Hai Li <hali@codeaurora.org>, Rob Clark <robdclark@gmail.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Nicholas Mc Guire <hofrat@osadl.org>
Subject: [PATCH] drm/msm: fix build warning - missing prototype
Date: Sat,  4 Apr 2015 04:39:35 +0200	[thread overview]
Message-ID: <1428115175-1985-1-git-send-email-hofrat@osadl.org> (raw)

fix build warning when building edp/edp_aux.o due to missing
prototype for edp_aux_transfer.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---
building drivers/gpu/drm/msm/msm.ko gives the following warning:
drivers/gpu/drm/msm/edp/edp_aux.c:118:9: warning: no previous prototype for 'edp_aux_transfer' [-Wmissing-prototypes]
 ssize_t edp_aux_transfer(struct drm_dp_aux *drm_aux, struct drm_dp_aux_msg *msg)
         ^

the fix is to simply add the missing prototype to drivers/gpu/drm/msm/edp/edp.h

This was compile tested with qcom_defconfig + 
CONFIG_DRM=m (implies CONFIG_DRM_MSM=m)

Patch is against 4.0-rc6 (localversion-next is -next-20150402)

 drivers/gpu/drm/msm/edp/edp.h |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/msm/edp/edp.h b/drivers/gpu/drm/msm/edp/edp.h
index ba5bedd..93d819c 100644
--- a/drivers/gpu/drm/msm/edp/edp.h
+++ b/drivers/gpu/drm/msm/edp/edp.h
@@ -58,6 +58,8 @@ void *msm_edp_aux_init(struct device *dev, void __iomem *regbase,
 void msm_edp_aux_destroy(struct device *dev, struct edp_aux *aux);
 irqreturn_t msm_edp_aux_irq(struct edp_aux *aux, u32 isr);
 void msm_edp_aux_ctrl(struct edp_aux *aux, int enable);
+ssize_t edp_aux_transfer(struct drm_dp_aux *drm_aux,
+			 struct drm_dp_aux_msg *msg);
 
 /* Phy */
 bool msm_edp_phy_ready(struct edp_phy *phy);
-- 
1.7.10.4


             reply	other threads:[~2015-04-04  2:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-04  2:39 Nicholas Mc Guire [this message]
2015-04-04 14:01 ` Rob Clark
2015-04-05  3:37   ` Nicholas Mc Guire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428115175-1985-1-git-send-email-hofrat@osadl.org \
    --to=hofrat@osadl.org \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hali@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®