From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Olof Johansson <olof@lixom.net>
Cc: Lee Jones <lee.jones@linaro.org>,
Doug Anderson <dianders@chromium.org>,
Bill Richardson <wfrichar@chromium.org>,
Simon Glass <sjg@google.com>,
Gwendal Grignou <gwendal@google.com>,
Stephen Barber <smbarber@chromium.org>,
Filipe Brandenburger <filbranden@google.com>,
Todd Broch <tbroch@chromium.org>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Gwendal Grignou <gwendal@chromium.org>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Subject: [RESEND PATCH 5/8] mfd: cros-ec: Support multiple EC in a system
Date: Mon, 6 Apr 2015 18:15:03 +0200 [thread overview]
Message-ID: <1428336906-14906-6-git-send-email-javier.martinez@collabora.co.uk> (raw)
In-Reply-To: <1428336906-14906-1-git-send-email-javier.martinez@collabora.co.uk>
From: Gwendal Grignou <gwendal@chromium.org>
Chromebooks can have more than one Embedded Controller so the
cros_ec device id has to be incremented for each EC registered.
Add code to handle multiple EC. First ec found is cros-ec0,
second cros-ec1 and so on.
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Dmitry Torokhov <dtor@chromium.org>
Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
drivers/mfd/cros_ec.c | 7 ++++++-
drivers/platform/chrome/cros_ec_dev.c | 4 ++--
include/linux/mfd/cros_ec.h | 2 ++
3 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
index c532dbca7404..70f6e55a096e 100644
--- a/drivers/mfd/cros_ec.c
+++ b/drivers/mfd/cros_ec.c
@@ -28,6 +28,8 @@
#define EC_COMMAND_RETRIES 50
+static int dev_id;
+
int cros_ec_prepare_tx(struct cros_ec_device *ec_dev,
struct cros_ec_command *msg)
{
@@ -130,6 +132,8 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
struct device *dev = ec_dev->dev;
int err = 0;
+ ec_dev->id = dev_id;
+
if (ec_dev->din_size) {
ec_dev->din = devm_kzalloc(dev, ec_dev->din_size, GFP_KERNEL);
if (!ec_dev->din)
@@ -143,7 +147,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
mutex_init(&ec_dev->lock);
- err = mfd_add_devices(dev, 0, cros_devs,
+ err = mfd_add_devices(dev, ec_dev->id, cros_devs,
ARRAY_SIZE(cros_devs),
NULL, ec_dev->irq, NULL);
if (err) {
@@ -159,6 +163,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
return err;
}
#endif
+ dev_id += ARRAY_SIZE(cros_devs);
dev_info(dev, "Chrome EC device registered\n");
diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chrome/cros_ec_dev.c
index e7e50f18097f..7173f0ea6ae5 100644
--- a/drivers/platform/chrome/cros_ec_dev.c
+++ b/drivers/platform/chrome/cros_ec_dev.c
@@ -191,7 +191,7 @@ static int ec_device_probe(struct platform_device *pdev)
{
struct cros_ec_device *ec = dev_get_drvdata(pdev->dev.parent);
int retval = -ENOTTY;
- dev_t devno = MKDEV(ec_major, 0);
+ dev_t devno = MKDEV(ec_major, ec->id);
/* Instantiate it (and remember the EC) */
cdev_init(&ec->cdev, &fops);
@@ -203,7 +203,7 @@ static int ec_device_probe(struct platform_device *pdev)
}
ec->vdev = device_create(cros_class, NULL, devno, ec,
- CROS_EC_DEV_NAME);
+ CROS_EC_DEV_NAME "%d", ec->id);
if (IS_ERR(ec->vdev)) {
retval = PTR_ERR(ec->vdev);
dev_err(&pdev->dev, ": failed to create device\n");
diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h
index 7eee38abd02a..2bee6ac74ffb 100644
--- a/include/linux/mfd/cros_ec.h
+++ b/include/linux/mfd/cros_ec.h
@@ -72,6 +72,7 @@ struct cros_ec_command {
*
* @priv: Private data
* @irq: Interrupt to use
+ * @id: Device id
* @din: input buffer (for data from EC)
* @dout: output buffer (for data to EC)
* \note
@@ -106,6 +107,7 @@ struct cros_ec_device {
/* These are used to implement the platform-specific interface */
void *priv;
int irq;
+ int id;
uint8_t *din;
uint8_t *dout;
int din_size;
--
2.1.4
next prev parent reply other threads:[~2015-04-06 16:15 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 16:14 [RESEND PATCH 0/8] cros_ec: Add multiple EC and protocol v3 support Javier Martinez Canillas
2015-04-06 16:14 ` [RESEND PATCH 1/8] mfd: cros ec: Remove parent field Javier Martinez Canillas
2015-04-23 20:15 ` Gwendal Grignou
2015-04-29 10:37 ` Lee Jones
2015-05-05 9:06 ` Javier Martinez Canillas
2015-05-05 10:54 ` Lee Jones
2015-05-09 1:38 ` Javier Martinez Canillas
2015-04-06 16:15 ` [RESEND PATCH 2/8] platform/chrome: cros_ec_lpc - Use existing function to check EC result Javier Martinez Canillas
2015-04-26 1:33 ` Gwendal Grignou
2015-04-06 16:15 ` [RESEND PATCH 3/8] mfd: cros_ec: Instantiate sub-devices from device tree Javier Martinez Canillas
2015-04-26 1:34 ` Gwendal Grignou
2015-04-29 10:39 ` Lee Jones
2015-05-05 9:21 ` Javier Martinez Canillas
2015-05-05 10:53 ` Lee Jones
2015-05-05 10:57 ` Javier Martinez Canillas
2015-04-06 16:15 ` [RESEND PATCH 4/8] mfd: cros_ec: Use a zero-length array for command data Javier Martinez Canillas
2015-04-16 9:45 ` Heiko Stübner
2015-04-16 9:55 ` Javier Martinez Canillas
2015-04-24 5:19 ` Gwendal Grignou
2015-05-05 15:53 ` Javier Martinez Canillas
2015-04-24 20:29 ` Gwendal Grignou
2015-05-05 15:57 ` Javier Martinez Canillas
2015-04-06 16:15 ` Javier Martinez Canillas [this message]
2015-04-23 23:54 ` [RESEND PATCH 5/8] mfd: cros-ec: Support multiple EC in a system Gwendal Grignou
2015-05-05 15:40 ` Javier Martinez Canillas
2015-04-06 16:15 ` [RESEND PATCH 6/8] mfd: cros_ec: rev cros_ec_commands.h Javier Martinez Canillas
2015-04-26 1:35 ` Gwendal Grignou
2015-04-29 10:45 ` Lee Jones
2015-04-06 16:15 ` [RESEND PATCH 7/8] mfd: cros_ec: add proto v3 skeleton Javier Martinez Canillas
2015-04-26 1:39 ` Gwendal Grignou
2015-05-05 15:59 ` Javier Martinez Canillas
2015-04-06 16:15 ` [RESEND PATCH 8/8] mfd: cros_ec: add bus-specific proto v3 code Javier Martinez Canillas
2015-04-26 1:39 ` Gwendal Grignou
2015-04-16 7:29 ` [RESEND PATCH 0/8] cros_ec: Add multiple EC and protocol v3 support Javier Martinez Canillas
2015-04-16 9:49 ` Heiko Stübner
2015-04-16 10:24 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428336906-14906-6-git-send-email-javier.martinez@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=dianders@chromium.org \
--cc=filbranden@google.com \
--cc=gwendal@chromium.org \
--cc=gwendal@google.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sjg@google.com \
--cc=smbarber@chromium.org \
--cc=tbroch@chromium.org \
--cc=wfrichar@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®