mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hp.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org,
	the arch/x86 maintainers <x86@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>, Boaz Harrosh <boaz@plexistor.com>
Subject: Re: [PATCH] x86: Revert E820_PRAM change in e820_end_pfn()
Date: Mon, 06 Apr 2015 12:36:17 -0600	[thread overview]
Message-ID: <1428345377.31093.137.camel@misato.fc.hp.com> (raw)
In-Reply-To: <CAE9FiQXNobC1_0YFS1dgy7Ae+vZFU783ttuBsSyw67wXbz2fCg@mail.gmail.com>

On Mon, 2015-04-06 at 11:29 -0700, Yinghai Lu wrote:
> On Mon, Apr 6, 2015 at 10:47 AM, Toshi Kani <toshi.kani@hp.com> wrote:
> > 'Commit ec776ef6bbe17 ("x86/mm: Add support for the non-standard
> > protected e820 type")' added E820_PRAM ranges, which do not have
> > have struct-page.  Therefore, there is no need to update max_pfn
> > to cover the E820_PRAM ranges.  Revert the change made to account
> > E820_PRAM as RAM in e820_end_pfn() in the commit.
> >
> > Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> > Signed-off-by: Toshi Kani <toshi.kani@hp.com>
> > Tested-by: Christoph Hellwig <hch@lst.de>
> > ---
> > The patch is based on the tip branch.
> > ---
> >  arch/x86/kernel/e820.c |    6 +-----
> >  1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
> > index e2ce85d..4dfe4bd 100644
> > --- a/arch/x86/kernel/e820.c
> > +++ b/arch/x86/kernel/e820.c
> > @@ -763,11 +763,7 @@ static unsigned long __init e820_end_pfn(unsigned long limit_pfn)
> >                 unsigned long start_pfn;
> >                 unsigned long end_pfn;
> >
> > -               /*
> > -                * Persistent memory is accounted as ram for purposes of
> > -                * establishing max_pfn and mem_map.
> > -                */
> > -               if (ei->type != E820_RAM && ei->type != E820_PRAM)
> > +               if (ei->type != E820_RAM)
> >                         continue;
> >
> >                 start_pfn = ei->addr >> PAGE_SHIFT;
> 
> Please use attached for code change.

Will do.

Thanks,
-Toshi



      reply	other threads:[~2015-04-06 18:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-06 17:47 Toshi Kani
2015-04-06 18:29 ` Yinghai Lu
2015-04-06 18:36   ` Toshi Kani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428345377.31093.137.camel@misato.fc.hp.com \
    --to=toshi.kani@hp.com \
    --cc=boaz@plexistor.com \
    --cc=hch@lst.de \
    --cc=hpa@zytor.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@ml01.01.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®