From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Andy Gross <agross@codeaurora.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>
Subject: [PATCH v3 2/5] regulator: qcom: Don't enable DRMS in driver
Date: Mon, 6 Apr 2015 16:33:57 -0700 [thread overview]
Message-ID: <1428363240-2027-3-git-send-email-bjorn.andersson@sonymobile.com> (raw)
In-Reply-To: <1428363240-2027-1-git-send-email-bjorn.andersson@sonymobile.com>
The driver itself should not flag regulators as being DRMS compatible,
this should come from board or dt files.
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
---
No changes since v2
drivers/regulator/qcom_rpm-regulator.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/regulator/qcom_rpm-regulator.c b/drivers/regulator/qcom_rpm-regulator.c
index 15e07c2..ddca8cb 100644
--- a/drivers/regulator/qcom_rpm-regulator.c
+++ b/drivers/regulator/qcom_rpm-regulator.c
@@ -732,10 +732,6 @@ static int rpm_reg_probe(struct platform_device *pdev)
return -EINVAL;
}
- /* Regulators with ia property suppports drms */
- if (vreg->parts->ia.mask)
- initdata->constraints.valid_ops_mask |= REGULATOR_CHANGE_DRMS;
-
key = "bias-pull-down";
if (of_property_read_bool(pdev->dev.of_node, key)) {
ret = rpm_reg_set(vreg, &vreg->parts->pd, 1);
--
1.8.2.2
next prev parent reply other threads:[~2015-04-06 23:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 23:33 [PATCH v3 0/5] Refactor Qualcomm RPM regulator to single platform_device Bjorn Andersson
2015-04-06 23:33 ` [PATCH v3 1/5] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes Bjorn Andersson
2015-04-07 6:39 ` Lee Jones
2015-04-06 23:33 ` Bjorn Andersson [this message]
2015-04-07 11:11 ` [PATCH v3 2/5] regulator: qcom: Don't enable DRMS in driver Mark Brown
2015-04-07 13:45 ` Bjorn Andersson
2015-04-06 23:33 ` [PATCH v3 3/5] regulator: qcom: Refactor of-parsing code Bjorn Andersson
2015-04-06 23:33 ` [PATCH v3 4/5] regulator: qcom: Rework to single platform device Bjorn Andersson
2015-04-06 23:40 ` Stephen Boyd
2015-04-06 23:34 ` [PATCH v3 5/5] regulator: qcom: Tidy up probe() Bjorn Andersson
2015-04-06 23:40 ` Stephen Boyd
2015-04-08 11:23 ` [PATCH v3 0/5] Refactor Qualcomm RPM regulator to single platform_device Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428363240-2027-3-git-send-email-bjorn.andersson@sonymobile.com \
--to=bjorn.andersson@sonymobile.com \
--cc=agross@codeaurora.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®