From: Zhen Lei <thunder.leizhen@huawei.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: Zefan Li <lizefan@huawei.com>, Xinwei Hu <huxinwei@huawei.com>,
"Tianhong Ding" <dingtianhong@huawei.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
"Yun Wu" <wuyun.wu@huawei.com>,
Zhen Lei <thunder.leizhen@huawei.com>
Subject: [PATCH 3/3] irqchip/gicv3-its: treat type reserved as 0x0
Date: Tue, 7 Apr 2015 15:47:34 +0800 [thread overview]
Message-ID: <1428392854-3228-3-git-send-email-thunder.leizhen@huawei.com> (raw)
In-Reply-To: <1428392854-3228-1-git-send-email-thunder.leizhen@huawei.com>
1. We don't known how many memory needed by type reserved. It's good to
take no care about it.
2. Remove unused macro definition and name of type reserved.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/irqchip/irq-gic-v3-its.c | 19 +++++++++++--------
include/linux/irqchip/arm-gic-v3.h | 4 ----
2 files changed, 11 insertions(+), 12 deletions(-)
diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index bbf9504..d649910 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -777,11 +777,7 @@ static int __init its_alloc_lpi_tables(void)
static const char *its_base_type_string[] = {
[GITS_BASER_TYPE_DEVICE] = "Devices",
[GITS_BASER_TYPE_VCPU] = "Virtual CPUs",
- [GITS_BASER_TYPE_RESERVED3] = "Reserved (3)",
[GITS_BASER_TYPE_COLLECTION] = "Interrupt Collections",
- [GITS_BASER_TYPE_RESERVED5] = "Reserved (5)",
- [GITS_BASER_TYPE_RESERVED6] = "Reserved (6)",
- [GITS_BASER_TYPE_RESERVED7] = "Reserved (7)",
};
static void its_free_tables(struct its_node *its)
@@ -814,9 +810,6 @@ static int its_alloc_tables(struct its_node *its)
void *base;
switch (type) {
- case GITS_BASER_TYPE_NONE:
- continue;
-
/*
* Allocate as many entries as required to fit the
* range of device IDs that the ITS can grok... The ID
@@ -833,9 +826,19 @@ static int its_alloc_tables(struct its_node *its)
break;
}
- default:
+ case GITS_BASER_TYPE_VCPU:
+ case GITS_BASER_TYPE_COLLECTION:
alloc_size = PAGE_SIZE;
break;
+
+ /*
+ * Here treat type Reserved as 0x0(NONE). If type reserved need
+ * memory, it should be allocated by BIOS/UEFI, OS take no care
+ * about it.
+ */
+ case GITS_BASER_TYPE_NONE:
+ default:
+ continue;
}
psz = PAGE_SIZE;
diff --git a/include/linux/irqchip/arm-gic-v3.h b/include/linux/irqchip/arm-gic-v3.h
index 67f5779..212df88 100644
--- a/include/linux/irqchip/arm-gic-v3.h
+++ b/include/linux/irqchip/arm-gic-v3.h
@@ -233,11 +233,7 @@
#define GITS_BASER_TYPE_NONE 0
#define GITS_BASER_TYPE_DEVICE 1
#define GITS_BASER_TYPE_VCPU 2
-#define GITS_BASER_TYPE_RESERVED3 3
#define GITS_BASER_TYPE_COLLECTION 4
-#define GITS_BASER_TYPE_RESERVED5 5
-#define GITS_BASER_TYPE_RESERVED6 6
-#define GITS_BASER_TYPE_RESERVED7 7
/*
* ITS commands
--
1.8.0
next prev parent reply other threads:[~2015-04-07 7:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 7:47 [PATCH 1/3] irqchip/gicv3-its: Adjust the implementation of its_alloc_tables Zhen Lei
2015-04-07 7:47 ` [PATCH 2/3] irqchip/gicv3-its: remove GITS_BASER_TYPE_CPU base on latest spec Zhen Lei
2015-04-07 7:47 ` Zhen Lei [this message]
2015-04-07 9:33 ` [PATCH 1/3] irqchip/gicv3-its: Adjust the implementation of its_alloc_tables Marc Zyngier
2015-04-07 12:32 ` leizhen
2015-04-07 13:02 ` Marc Zyngier
2015-04-07 14:54 ` leizhen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428392854-3228-3-git-send-email-thunder.leizhen@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=dingtianhong@huawei.com \
--cc=huxinwei@huawei.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
--cc=wangkefeng.wang@huawei.com \
--cc=wuyun.wu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®