mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Song Liu <songliubraving@fb.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: open list <linux-kernel@vger.kernel.org>,
	Kernel Team <Kernel-team@fb.com>, David Xu <dxu@fb.com>,
	Andrew Hall <hall@fb.com>, Steven Rostedt <rostedt@goodmis.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] perf/kprobe: maxactive for fd-based kprobe (pmu perf_kprobe)
Date: Thu, 10 Oct 2019 22:44:42 +0000	[thread overview]
Message-ID: <14283CB6-F665-47BA-9A77-54D2BBC85FD5@fb.com> (raw)
In-Reply-To: <20191008083420.cecebd6afdf5c34074565195@kernel.org>



> On Oct 7, 2019, at 4:34 PM, Masami Hiramatsu <mhiramat@kernel.org> wrote:
> 
> Hi,
> 
> On Mon, 7 Oct 2019 15:31:11 -0700
> Song Liu <songliubraving@fb.com> wrote:
> 
>> Enable specifying maxactive for fd based kretprobe. This will be useful
>> for tracing tools like bcc and bpftrace. [1] discussed the need of this
>> in bpftrace. Use highest highest 12 bit (bit 52-63) to allow maximal
>> maxactive of 4095.
>> 
>> [1] https://github.com/iovisor/bpftrace/issues/835
> 
> From the view point of trace_kprobe, this looks good to me.
> 
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thanks Masami!

Hi Peter and Steven, 

Could you please share your comments on this?

Thanks,
Song

  reply	other threads:[~2019-10-10 22:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 22:31 Song Liu
2019-10-07 23:34 ` Masami Hiramatsu
2019-10-10 22:44   ` Song Liu [this message]
2019-11-13 19:13 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14283CB6-F665-47BA-9A77-54D2BBC85FD5@fb.com \
    --to=songliubraving@fb.com \
    --cc=Kernel-team@fb.com \
    --cc=dxu@fb.com \
    --cc=hall@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®