From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932219AbbDHOi1 (ORCPT ); Wed, 8 Apr 2015 10:38:27 -0400 Received: from mga03.intel.com ([134.134.136.65]:16582 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754443AbbDHOiX (ORCPT ); Wed, 8 Apr 2015 10:38:23 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,544,1422950400"; d="scan'208";a="478359755" From: Irina Tirdea To: Jonathan Cameron , linux-iio@vger.kernel.org, Hartmut Knaack Cc: linux-kernel@vger.kernel.org, Irina Tirdea Subject: [PATCH 6/8] iio: accel: mma9553: check input value for activity period Date: Wed, 8 Apr 2015 17:37:35 +0300 Message-Id: <1428503857-9081-7-git-send-email-irina.tirdea@intel.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1428503857-9081-1-git-send-email-irina.tirdea@intel.com> References: <1428503857-9081-1-git-send-email-irina.tirdea@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When setting the activity period, the value introduced by the user in sysfs is not checked for validity. Add a boundary check so that only allowed values are reported as suuccesfully written to device. Signed-off-by: Irina Tirdea Suggested-by: Hartmut Knaack --- drivers/iio/accel/mma9553.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/iio/accel/mma9553.c b/drivers/iio/accel/mma9553.c index 57868fb..96e4708 100644 --- a/drivers/iio/accel/mma9553.c +++ b/drivers/iio/accel/mma9553.c @@ -839,6 +839,9 @@ static int mma9553_write_event_value(struct iio_dev *indio_dev, case IIO_EV_INFO_PERIOD: switch (chan->type) { case IIO_ACTIVITY: + if (val < 0 || val > MMA9553_ACTIVITY_THD_TO_SEC( + MMA9553_MAX_ACTTHD)) + return -EINVAL; mutex_lock(&data->mutex); ret = mma9553_set_config(data, MMA9553_REG_CONF_ACTTHD, &data->conf.actthd, -- 1.9.1