From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755490AbbDIPNN (ORCPT ); Thu, 9 Apr 2015 11:13:13 -0400 Received: from mail4.surf-town.net ([212.97.132.44]:35758 "EHLO mailgw9.surf-town.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753161AbbDIPNJ (ORCPT ); Thu, 9 Apr 2015 11:13:09 -0400 X-Greylist: delayed 526 seconds by postgrey-1.27 at vger.kernel.org; Thu, 09 Apr 2015 11:13:09 EDT X-Spam-Flag: NO X-Spam-Score: -1.44 From: Pelle Nilsson To: broonie@kernel.org Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, nios2-dev@lists.rocketboards.org Subject: [PATCH 0/1] Fix NULL pointer dereference Date: Thu, 9 Apr 2015 17:03:41 +0200 Message-Id: <1428591822-24279-1-git-send-email-per.nilsson@xelmo.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As I reported earlier, spi-altera driver is broken and causes a kernel panic due to a NULL pointer dereference during first SPI transaction. On a closer look, it turned out that the setup_transfer() bitbang callback is mandatory when the txrx_bufs() callback is present. It was therefore an error to remove it in commit 30af9b558a56. This patch simply adds back an empty implementation of the callback. Pelle Nilsson (1): spi: altera: Add empty implementation of setup_transfer callback drivers/spi/spi-altera.c | 6 ++++++ 1 file changed, 6 insertions(+) -- 1.9.1