mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Denys Vlasenko <dvlasenk@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Denys Vlasenko <dvlasenk@redhat.com>,
	Jiri Olsa <jolsa@redhat.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	x86@kernel.org
Subject: [PATCH 2/4] perf/x86_64: get_regs_user: Do report user_regs->cx while we are in syscall
Date: Fri, 10 Apr 2015 15:06:57 +0200	[thread overview]
Message-ID: <1428671219-29341-2-git-send-email-dvlasenk@redhat.com> (raw)
In-Reply-To: <1428671219-29341-1-git-send-email-dvlasenk@redhat.com>

Yes, it is true that cx contains return address.
It's not clear why we trash it.
Stop doing that.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Jiri Olsa <jolsa@redhat.com>
CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
CC: Paul Mackerras <paulus@samba.org>
CC: Ingo Molnar <mingo@redhat.com>
CC: Arnaldo Carvalho de Melo <acme@kernel.org>
CC: x86@kernel.org
CC: linux-kernel@vger.kernel.org
---
 arch/x86/kernel/perf_regs.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/kernel/perf_regs.c b/arch/x86/kernel/perf_regs.c
index 7ab198a..a8d4e48 100644
--- a/arch/x86/kernel/perf_regs.c
+++ b/arch/x86/kernel/perf_regs.c
@@ -177,8 +177,6 @@ void perf_get_regs_user(struct perf_regs *regs_user,
 		 * than just blindly copying user_regs.
 		 */
 		regs_user->abi = PERF_SAMPLE_REGS_ABI_64;
-		/* usually contains return address (same as ->ip) */
-		regs_user_copy->cx = -1;
 	} else {
 		/* We're probably in an interrupt or exception. */
 		regs_user->abi = user_64bit_mode(user_regs) ?
-- 
1.8.1.4


  reply	other threads:[~2015-04-10 13:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-10 13:06 [PATCH 1/4] perf/x86_64: get_regs_user: Do not guess user_regs->cs,ss,sp Denys Vlasenko
2015-04-10 13:06 ` Denys Vlasenko [this message]
2015-04-12 17:26   ` [tip:x86/asm] perf/x86/64: Do report user_regs-> cx while we are in syscall, in get_regs_user() tip-bot for Denys Vlasenko
2015-04-10 13:06 ` [PATCH 3/4] perf/x86_64: get_regs_user: Simplify regs_user->abi setting code Denys Vlasenko
2015-04-12 17:26   ` [tip:x86/asm] perf/x86/64: Simplify regs_user-> abi setting code in get_regs_user() tip-bot for Denys Vlasenko
2015-04-10 13:06 ` [PATCH 4/4] perf/x86_64: get_regs_user: Report regs_user->ax too Denys Vlasenko
2015-04-12 17:26   ` [tip:x86/asm] perf/x86/64: Report regs_user-> ax too in get_regs_user() tip-bot for Denys Vlasenko
2015-04-12 17:26 ` [tip:x86/asm] perf/x86/64: Do not guess user_regs->cs, ss, sp " tip-bot for Denys Vlasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428671219-29341-2-git-send-email-dvlasenk@redhat.com \
    --to=dvlasenk@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®