From: Paul Bolle <pebolle@tiscali.nl>
To: Stefan Agner <stefan@agner.ch>
Cc: shawn.guo@linaro.org, kernel@pengutronix.de,
linux@arm.linux.org.uk, u.kleine-koenig@pengutronix.de,
jason@lakedaemon.net, olof@lixom.net, arnd@arndb.de,
daniel.lezcano@linaro.org, tglx@linutronix.de,
mark.rutland@arm.com, pawel.moll@arm.com, robh+dt@kernel.org,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
marc.zyngier@arm.com, mcoquelin.stm32@gmail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 09/11] ARM: vf610: enable Cortex-M4 configuration on Vybrid SoC
Date: Fri, 10 Apr 2015 19:54:00 +0200 [thread overview]
Message-ID: <1428688440.17822.33.camel@x220> (raw)
In-Reply-To: <1428609855-27657-10-git-send-email-stefan@agner.ch>
Just two whitespace nits. (Please don't tell anyone, I'm a bit
embarrassed that I even spot them, let alone that I comment on them.)
On Thu, 2015-04-09 at 22:04 +0200, Stefan Agner wrote:
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -629,10 +631,26 @@ config SOC_IMX6SX
> help
> This enables support for Freescale i.MX6 SoloX processor.
>
> +
This second empty line is unneeded.
> +config SOC_LS1021A
> + bool "Freescale LS1021A support"
> + select ARM_GIC
> + select HAVE_ARM_ARCH_TIMER
> + select PCI_DOMAINS if PCI
> + select ZONE_DMA if ARM_LPAE
> +
Please drop this empty line.
> + help
> + This enable support for Freescale LS1021A processor.
> +
> +endif
> +
> +comment "Cortex-A/Cortex-M asymmetric multiprocessing platforms"
> +
> +if ARCH_MULTI_V7 || ARM_SINGLE_ARMV7M
> +
> config SOC_VF610
> bool "Vybrid Family VF610 support"
> - select IRQ_DOMAIN_HIERARCHY
> - select ARM_GIC
> + select ARM_GIC if ARCH_MULTI_V7
> select PINCTRL_VF610
> select PL310_ERRATA_769419 if CACHE_L2X0
>
Thanks,
Paul Bolle
next prev parent reply other threads:[~2015-04-10 17:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 20:04 [PATCH v5 00/11] ARM: vf610m4: Add Vybrid Cortex-M4 support Stefan Agner
2015-04-09 20:04 ` [PATCH v5 01/11] genirq: generic chip: support hierarchy domain Stefan Agner
2015-04-09 20:04 ` [PATCH v5 02/11] irqchip: nvic: support hierarchy irq domain Stefan Agner
2015-04-09 20:04 ` [PATCH v5 03/11] irqchip: vf610-mscm: support NVIC parent Stefan Agner
2015-04-09 20:04 ` [PATCH v5 04/11] ARM: ARMv7M: define size of vector table for Vybrid Stefan Agner
2015-04-09 20:04 ` [PATCH v5 05/11] clocksource: add dependencies for Vybrid pit clocksource Stefan Agner
2015-04-09 20:04 ` [PATCH v5 06/11] ARM: unify MMU/!MMU addruart calls Stefan Agner
2015-04-09 20:04 ` [PATCH v5 07/11] ARM: introduce ARM_SINGLE_ARMV7M for ARMv7-M platforms Stefan Agner
2015-04-09 20:04 ` [PATCH v5 08/11] ARM: efm32: use ARM_SINGLE_ARMV7M Stefan Agner
2015-04-09 20:04 ` [PATCH v5 09/11] ARM: vf610: enable Cortex-M4 configuration on Vybrid SoC Stefan Agner
2015-04-10 17:54 ` Paul Bolle [this message]
2015-04-09 20:04 ` [PATCH v5 10/11] ARM: dts: add support for Vybrid running on Cortex-M4 Stefan Agner
2015-04-09 20:04 ` [PATCH v5 11/11] ARM: vf610m4: add defconfig for Linux on Vybrids Cortex-M4 Stefan Agner
2015-04-10 8:50 ` [PATCH v5 00/11] ARM: vf610m4: Add Vybrid Cortex-M4 support Maxime Coquelin
2015-04-11 0:13 ` Jason Cooper
2015-04-13 23:27 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428688440.17822.33.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=stefan@agner.ch \
--cc=tglx@linutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome