From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755362AbbDKQUE (ORCPT ); Sat, 11 Apr 2015 12:20:04 -0400 Received: from smtprelay0101.hostedemail.com ([216.40.44.101]:36861 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754231AbbDKQUB (ORCPT ); Sat, 11 Apr 2015 12:20:01 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:968:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2691:2828:3138:3139:3140:3141:3142:3622:3865:3866:3870:3871:3872:3873:4321:4605:5007:6119:6261:6742:7903:8957:10004:10400:10848:11232:11658:11914:12517:12519:12555:12740:13069:13161:13229:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: pin22_1cd96ac7f2039 X-Filterd-Recvd-Size: 1666 Message-ID: <1428769196.5413.55.camel@perches.com> Subject: Re: [PATCH] drivers/usb/core: hcd.c: Removed all space warnings from checkpatch.pl From: Joe Perches To: Chase Metzger Cc: gregkh@linuxfoundation.org, stern@rowland.harvard.edu, balbi@ti.com, dan.j.williams@intel.com, antoine.tenart@free-electrons.com, pmladek@suse.cz, sojka@merica.cz, xerofoify@gmail.com, sergei.shtylyov@cogentembedded.com, rafael.j.wysocki@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sat, 11 Apr 2015 09:19:56 -0700 In-Reply-To: <1428746673-12352-1-git-send-email-chasemetzger15@gmail.com> References: <1428746673-12352-1-git-send-email-chasemetzger15@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2015-04-11 at 03:04 -0700, Chase Metzger wrote: > Removed all(except false positives, from calculations) space prohibited warnings generated by > checkpatch.pl. False positives? Please describe them. The only thing I believe you elided was the use of a BitTime macro which in my opinion should be used as a function. drivers/usb/core/hcd.c: tmp = (67667L * (31L + 10L * BitTime (bytecount))) / 1000L; as it is in the include file: include/linux/usb/hcd.h: + (2083UL * (3 + BitTime(bytes))))/1000 \