mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hp.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-acpi@vger.kernel.org, Xie XiuQi <xiexiuqi@huawei.com>,
	guohanjun@huawei.com, hanjun.guo@linaro.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI / scan: Annotate physical_node_lock in acpi_scan_is_offline()
Date: Thu, 16 Apr 2015 13:01:57 -0600	[thread overview]
Message-ID: <1429210917.17259.5.camel@misato.fc.hp.com> (raw)
In-Reply-To: <2181841.0nPiIAbDNm@vostro.rjw.lan>

On Sat, 2015-04-11 at 01:31 +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> acpi_scan_is_offline() may be called under the physical_node_lock
> of the given device object's parent, so prevent lockdep from
> complaining about that by annotating that instance with
> SINGLE_DEPTH_NESTING.
> 
> Reported-by: Xie XiuQi <xiexiuqi@huawei.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Agreed that the issue is likely with the lock-class.  Assuming Xie's
test goes well (we will need to wait for that :),

Reviewed-by: Toshi Kani <toshi.kani@hp.com>

Thanks,
-Toshi



  parent reply	other threads:[~2015-04-16 19:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-07  9:03 [PATCH] ACPI / HOTPLUG: fix device->physical_node_lock deadlock Xie XiuQi
2015-04-07 11:22 ` Rafael J. Wysocki
2015-04-07 11:50   ` Rafael J. Wysocki
2015-04-10 23:31     ` [PATCH] ACPI / scan: Annotate physical_node_lock in acpi_scan_is_offline() Rafael J. Wysocki
2015-04-13  1:28       ` Xie XiuQi
2015-04-13  8:27       ` Hanjun Guo
2015-04-13 13:48         ` Rafael J. Wysocki
2015-04-16 19:01       ` Toshi Kani [this message]
2015-04-17  7:19       ` Xie XiuQi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429210917.17259.5.camel@misato.fc.hp.com \
    --to=toshi.kani@hp.com \
    --cc=guohanjun@huawei.com \
    --cc=hanjun.guo@linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=xiexiuqi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®