mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] x86_64: use -mskip-rax-setup when available
Date: Mon, 20 Apr 2015 14:28:16 +0200	[thread overview]
Message-ID: <1429532896-10265-1-git-send-email-linux@rasmusvillemoes.dk> (raw)

gcc 5 supports the option -mskip-rax-setup to avoid emitting the
two-byte instruction xor %eax,%eax before a vararg function
call. Clearing %eax is redundant in the kernel, since no callee
expects any floating point arguments, and hence never use the incoming
value of %eax for anything.

For a defconfig kernel, the .text saving is around 26 kB:

$ size /tmp/vmlinux.{old,new}
   text    data     bss     dec     hex filename
12221850        1735352 1077248 15034450         e56852 /tmp/vmlinux.old
12195955        1735352 1077248 15008555         e5032b /tmp/vmlinux.new

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---

Nothing seems to have happened on the kernel side since H.J. Lu
implemented this in December.  Since gcc 5 is officially released
soon, I think it would be nice if this could soak in -next until the
next merge window.

 arch/x86/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index 2fda005bb334..00bc42c4cbd1 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -81,6 +81,8 @@ else
         KBUILD_CFLAGS += $(call cc-option,-mno-80387)
         KBUILD_CFLAGS += $(call cc-option,-mno-fp-ret-in-387)
 
+        KBUILD_CFLAGS += $(call cc-option,-mskip-rax-setup)
+
 	# Use -mpreferred-stack-boundary=3 if supported.
 	KBUILD_CFLAGS += $(call cc-option,-mpreferred-stack-boundary=3)
 
-- 
2.1.3


             reply	other threads:[~2015-04-20 12:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-20 12:28 Rasmus Villemoes [this message]
2015-04-20 15:07 ` Borislav Petkov
2015-04-20 20:24   ` Rasmus Villemoes
2015-04-20 20:41     ` Borislav Petkov
2015-04-23 11:00       ` Rasmus Villemoes
2015-04-23 12:29         ` Borislav Petkov
2015-04-23 12:55           ` Rasmus Villemoes
2015-04-23 13:12             ` Borislav Petkov
2015-04-23 12:55           ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429532896-10265-1-git-send-email-linux@rasmusvillemoes.dk \
    --to=linux@rasmusvillemoes.dk \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®