From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755378AbbDTM4w (ORCPT ); Mon, 20 Apr 2015 08:56:52 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:11093 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755326AbbDTM4h (ORCPT ); Mon, 20 Apr 2015 08:56:37 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Mon, 20 Apr 2015 05:55:46 -0700 From: Laxman Dewangan To: , , , , , CC: , , Laxman Dewangan Subject: [PATCH 2/3] regulator: max8973: make default/unset dvs gpio as invalid gpio Date: Mon, 20 Apr 2015 18:24:16 +0530 Message-ID: <1429534457-15515-3-git-send-email-ldewangan@nvidia.com> X-Mailer: git-send-email 1.8.1.5 In-Reply-To: <1429534457-15515-1-git-send-email-ldewangan@nvidia.com> References: <1429534457-15515-1-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If platform data has dvs-gpio value 0 as default/unset then make this as invalid gpio so that function gpio_is_valid() can return false on this case. Signed-off-by: Laxman Dewangan --- As discussed on the patch [PATCH] regulator: max8973: get rid of extra variable for gpio validity Adding handling of unset/default gpio on platform data which is set as 0. drivers/regulator/max8973-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/max8973-regulator.c b/drivers/regulator/max8973-regulator.c index 1890808..85fa2de 100644 --- a/drivers/regulator/max8973-regulator.c +++ b/drivers/regulator/max8973-regulator.c @@ -408,7 +408,7 @@ static int max8973_probe(struct i2c_client *client, } if (pdata) { - max->dvs_gpio = pdata->dvs_gpio; + max->dvs_gpio = (pdata->dvs_gpio) ? pdata->dvs_gpio : -EINVAL; max->enable_external_control = pdata->enable_ext_control; max->curr_gpio_val = pdata->dvs_def_state; max->curr_vout_reg = MAX8973_VOUT + pdata->dvs_def_state; -- 1.8.1.5