mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian Abbott <abbotti@mev.co.uk>
To: <driverdev-devel@linuxdriverproject.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ian Abbott <abbotti@mev.co.uk>,
	H Hartley Sweeten <hartleys@visionengravers.com>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH 0/2] staging: comedi: hide subdevice runflags stuff
Date: Tue, 21 Apr 2015 13:18:09 +0100	[thread overview]
Message-ID: <1429618691-7157-1-git-send-email-abbotti@mev.co.uk> (raw)

Keep the details of the comedi subdevice `runflags` member local to
"comedi_fops.c".  In particular, the usage of the
`COMEDI_SRF_FREE_SPRIV` run-flag doesn't really fit in all that well
with the others.  It's used as a marker to indicate the subdevice's
`private` pointer can be automatically freed by the subdevice
clean-up code, whereas the others are associated with the operation of
asynchronous comedi commands.  Abstract it's usage away in a couple of
new wrapper functions.

1) staging: comedi: wrap COMEDI_SRF_FREE_SPRIV usage
2) staging: comedi: move COMEDI_SRF_... macros to "comedi_fops.c"

 drivers/staging/comedi/comedi_fops.c               | 41 ++++++++++++++++++++--
 drivers/staging/comedi/comedi_internal.h           |  1 +
 drivers/staging/comedi/comedidev.h                 | 18 +---------
 drivers/staging/comedi/drivers.c                   |  2 +-
 .../staging/comedi/drivers/amplc_dio200_common.c   |  6 ++--
 5 files changed, 45 insertions(+), 23 deletions(-)

             reply	other threads:[~2015-04-21 12:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21 12:18 Ian Abbott [this message]
2015-04-21 12:18 ` [PATCH 1/2] staging: comedi: wrap COMEDI_SRF_FREE_SPRIV usage Ian Abbott
2015-04-21 12:18 ` [PATCH 2/2] staging: comedi: move COMEDI_SRF_... macros to "comedi_fops.c" Ian Abbott
2015-04-21 17:12 ` [PATCH 0/2] staging: comedi: hide subdevice runflags stuff Hartley Sweeten
2015-04-21 17:15   ` Moving comedi to mainline soon? Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429618691-7157-1-git-send-email-abbotti@mev.co.uk \
    --to=abbotti@mev.co.uk \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hartleys@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®