From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753341AbbDWG5f (ORCPT ); Thu, 23 Apr 2015 02:57:35 -0400 Received: from mail-ig0-f177.google.com ([209.85.213.177]:35658 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752731AbbDWG5e (ORCPT ); Thu, 23 Apr 2015 02:57:34 -0400 Message-ID: <1429772251.22254.35.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [PATCH 1/2] timer: Avoid waking up an idle-core by migrate running timer From: Eric Dumazet To: Thomas Gleixner Cc: Peter Zijlstra , viresh kumar , Ingo Molnar , linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, Steven Miao , shashim@codeaurora.org Date: Wed, 22 Apr 2015 23:57:31 -0700 In-Reply-To: References: <80182e47a7103608d2ddab7f62c0c3dffc99fdcc.1427782893.git.viresh.kumar@linaro.org> <5530C086.2020700@linaro.org> <1429653295.18561.16.camel@edumazet-glaptop2.roam.corp.google.com> <20150422152940.GC3007@worktop.Skamania.guest> <1429718577.18561.103.camel@edumazet-glaptop2.roam.corp.google.com> <1429732743.18561.134.camel@edumazet-glaptop2.roam.corp.google.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-04-22 at 23:56 +0200, Thomas Gleixner wrote: > -int get_nohz_timer_target(int pinned) > +int get_nohz_timer_target(void) > { > - int cpu = smp_processor_id(); > - int i; > + int i, cpu = smp_processor_id(); > struct sched_domain *sd; > > - if (pinned || !get_sysctl_timer_migration() || !idle_cpu(cpu)) > + if (!idle_cpu(cpu)) > return cpu; Maybe also test in_serving_softirq() ? if (in_serving_softirq() || !idle_cpu(cpu)) return cpu; There is a fundamental problem with networking load : Many cpus appear to be idle from scheduler perspective because no user/kernel task is running. CPUs servicing NIC queues can be very busy handling thousands of packets per second, yet have no user/kernel task running. idle_cpu() return code is : this cpu is idle. hmmmm, really ? cpus are busy, *and* have to access alien data/locks to activate timers that hardly fire anyway. When idle_cpu() finally gives the right indication, it is too late : ksoftirqd might be running on the wrong cpu. Innocent cpus, overwhelmed by a sudden timer load and locked into a service loop. This cannot resist to a DOS, and even with non malicious traffic, the overhead is high. Thanks.