From: Joe Perches <joe@perches.com>
To: Navya Sri Nizamkari <navyasri.tech@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: slicoss: Break string into two lines.
Date: Fri, 24 Apr 2015 11:59:28 -0700 [thread overview]
Message-ID: <1429901968.23327.8.camel@perches.com> (raw)
In-Reply-To: <20150424185228.GA1418@localhost>
On Sat, 2015-04-25 at 00:22 +0530, Navya Sri Nizamkari wrote:
> This patch fixes the checkpatch.pl warning
> about line over 80 characters.
Don't give checkpatch any respect when it's being stupid.
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
[]
> @@ -98,7 +98,8 @@
> #include "slic.h"
>
> static uint slic_first_init = 1;
> -static char *slic_banner = "Alacritech SLIC Technology(tm) Server and Storage Accelerator (Non-Accelerated)";
> +static char *slic_banner = "Alacritech SLIC Technology(tm) Server
> + and Storage Accelerator (Non-Accelerated)";
You've added a defect here as the string now contains a
newline and new tabs and spaces between "Server" and "and"
prev parent reply other threads:[~2015-04-24 18:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 18:52 Navya Sri Nizamkari
2015-04-24 18:59 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429901968.23327.8.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=navyasri.tech@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome