mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Robert Callicotte <rcallicotte@gmail.com>
Cc: greg@kroah.com, lidza.louina@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dgnc: Cleanup of unnecessary braces
Date: Fri, 24 Apr 2015 21:56:17 -0700	[thread overview]
Message-ID: <1429937777.23327.60.camel@perches.com> (raw)
In-Reply-To: <20150425044813.GA1584@lenny.callicotte.org>

On Fri, 2015-04-24 at 23:48 -0500, Robert Callicotte wrote:
> Removed curly braces and trailing whitespace from else clause.

Do please compile the files modified by your patches
_before_ sending them.

> Signed-off-by: Robert Callicotte <rcallicotte@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_tty.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
> index ce4187f..2418150 100644
> --- a/drivers/staging/dgnc/dgnc_tty.c
> +++ b/drivers/staging/dgnc/dgnc_tty.c
> @@ -898,9 +898,8 @@ void dgnc_check_queue_flow_control(struct channel_t *ch)
>  			ch->ch_bd->bd_ops->send_start_character(ch);
>  		}
>  		/* No FLOW */
> -		else {
> +		else
>  			/* Nothing needed. */
> -		}
>  	}
>  }
>  




      reply	other threads:[~2015-04-25  5:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-25  4:48 Robert Callicotte
2015-04-25  4:56 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429937777.23327.60.camel@perches.com \
    --to=joe@perches.com \
    --cc=greg@kroah.com \
    --cc=lidza.louina@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rcallicotte@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®