From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933200AbcBPQMk (ORCPT ); Tue, 16 Feb 2016 11:12:40 -0500 Received: from linuxhacker.ru ([217.76.32.60]:58900 "EHLO fiona.linuxhacker.ru" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S932352AbcBPQMi convert rfc822-to-8bit (ORCPT ); Tue, 16 Feb 2016 11:12:38 -0500 Subject: Re: [PATCH 43/45] staging/lustre/libcfs: Replace use of printk with pr_ Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=US-ASCII From: Oleg Drokin In-Reply-To: <1455602117.4046.45.camel@perches.com> Date: Tue, 16 Feb 2016 11:12:14 -0500 Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Linux Kernel Mailing List , Lustre Development List Content-Transfer-Encoding: 7BIT Message-Id: <142FFAE8-57BF-4B57-9959-4A1BFB5463AA@linuxhacker.ru> References: <1455601637-3847710-1-git-send-email-green@linuxhacker.ru> <1455601637-3847710-44-git-send-email-green@linuxhacker.ru> <1455602117.4046.45.camel@perches.com> To: Joe Perches X-Mailer: Apple Mail (2.1283) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Feb 16, 2016, at 12:55 AM, Joe Perches wrote: > On Tue, 2016-02-16 at 00:47 -0500, green@linuxhacker.ru wrote: >> From: Oleg Drokin >> >> This pacifies checkpatch amongst other things, also is shorter to write >> and avoiding calls to printk_ratelimit() is also good. > [] >> diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-tracefile.c b/drivers/staging/lustre/lustre/libcfs/linux/linux-tracefile.c > [] >> @@ -244,11 +244,11 @@ void cfs_print_to_console(struct ptldebug_header *hdr, int mask, >> } >> >> if ((mask & D_CONSOLE) != 0) { >> - printk("%s%s: %.*s", ptype, prefix, len, buf); >> + pr_err("%s%s: %.*s", ptype, prefix, len, buf); >> } else { >> - printk("%s%s: %d:%d:(%s:%d:%s()) %.*s", ptype, prefix, >> - hdr->ph_pid, hdr->ph_extern_pid, file, hdr->ph_line_num, >> - fn, len, buf); >> + pr_warn("%s%s: %d:%d:(%s:%d:%s()) %.*s", ptype, prefix, >> + hdr->ph_pid, hdr->ph_extern_pid, file, hdr->ph_line_num, >> + fn, len, buf); >> } >> } > > This breaks the currently correct output. Hm, you are right. Thanks! I guess this patch just needs some redoing. Greg, if you can skip this patch but still apply the rest of the series, that would be great. I just tested that the whole thing builds and runs fine with this patch omitted. Bye, Oleg