From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752329AbbDZTKh (ORCPT ); Sun, 26 Apr 2015 15:10:37 -0400 Received: from lb2-smtp-cloud3.xs4all.net ([194.109.24.26]:52268 "EHLO lb2-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115AbbDZTKc (ORCPT ); Sun, 26 Apr 2015 15:10:32 -0400 Message-ID: <1430075422.2927.131.camel@x220> Subject: Re: [PATCH v5 1/3] ARM: pxa: pxa_cplds: add lubbock and mainstone IO From: Paul Bolle To: Robert Jarzmik Cc: Daniel Mack , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Sun, 26 Apr 2015 21:10:22 +0200 In-Reply-To: <1429996403-13644-2-git-send-email-robert.jarzmik@free.fr> References: <1429996403-13644-1-git-send-email-robert.jarzmik@free.fr> <1429996403-13644-2-git-send-email-robert.jarzmik@free.fr> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2015-04-25 at 23:13 +0200, Robert Jarzmik wrote: > --- a/arch/arm/mach-pxa/Kconfig > +++ b/arch/arm/mach-pxa/Kconfig > +config PXA_SYSTEMS_CPLDS > + bool "Motherboard cplds" > + def_bool ARCH_LUBBOCK || MACH_MAINSTONE Just default ARCH_LUBBOCK || MACH_MAINSTONE should be enough. > + select MFD_CORE > + help > + This driver supports the Lubbock and Mainstone multifunction chip > + found on the pxa25x development platform system (Lubbock) and pxa27x > + development platform system (Mainstone). This IO board supports the > + interrupts handling, ethernet controller, flash chips, etc ... > --- a/arch/arm/mach-pxa/Makefile > +++ b/arch/arm/mach-pxa/Makefile > +obj-$(CONFIG_PXA_SYSTEMS_CPLDS) += pxa_cplds_irqs.o PXA_SYSTEMS_CPLDS is a bool symbol, so pxa_cplds_irqs.o will never be part of a module, correct? > --- /dev/null > +++ b/arch/arm/mach-pxa/pxa_cplds_irqs.c > +#include Since this is built-in only code this include is probably unneeded. > +MODULE_DEVICE_TABLE(of, cplds_id_table); MODULE_DEVICE_TABLE() will be preprocessed away for built-in only code. > +module_platform_driver(cplds_driver); Speaking from memory: for built-in only code this is equivalent to having a wrapper that only calls platform_driver_register(&cplds_driver); and have that wrapper marked as device_initcall() > +MODULE_DESCRIPTION("PXA Cplds interrupts driver"); > +MODULE_AUTHOR("Robert Jarzmik "); > +MODULE_LICENSE("GPL"); These three macros will effectively be preprocessed away for built-in only code. Thanks, Paul Bolle