mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Wang <yun.wang@profitbricks.com>
To: Roland Dreier <roland@kernel.org>,
	Sean Hefty <sean.hefty@intel.com>,
	Hal Rosenstock <hal@dev.mellanox.co.il>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Michael Wang <yun.wang@profitbricks.com>,
	Steve Wise <swise@opengridcomputing.com>,
	Tom Talpey <tom@talpey.com>,
	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	Doug Ledford <dledford@redhat.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Tom Tucker <tom@opengridcomputing.com>,
	Hoang-Nam Nguyen <hnguyen@de.ibm.com>,
	Christoph Raisch <raisch@de.ibm.com>,
	Mike Marciniszyn <infinipath@intel.com>,
	Eli Cohen <eli@mellanox.com>,
	Faisal Latif <faisal.latif@intel.com>,
	Jack Morgenstein <jackm@dev.mellanox.co.il>,
	Or Gerlitz <ogerlitz@mellanox.com>,
	Haggai Eran <haggaie@mellanox.com>,
	Devesh Sharma <Devesh.Sharma@Emulex.Com>,
	Liran Liss <liranl@mellanox.com>,
	Dave Goodell <dgoodell@cisco.com>
Subject: [PATCH v7 23/23] IB/Verbs: Use management helper cap_eth_ah()
Date: Tue, 28 Apr 2015 17:10:23 +0200	[thread overview]
Message-ID: <1430233823-7075-24-git-send-email-yun.wang@profitbricks.com> (raw)
In-Reply-To: <1430233823-7075-1-git-send-email-yun.wang@profitbricks.com>

Introduce helper cap_eth_ah() to help us check if the port of an
IB device support Ethernet Address Handler.

Cc: Hal Rosenstock <hal@dev.mellanox.co.il>
Cc: Steve Wise <swise@opengridcomputing.com>
Cc: Tom Talpey <tom@talpey.com>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Doug Ledford <dledford@redhat.com>
Cc: Ira Weiny <ira.weiny@intel.com>
Cc: Sean Hefty <sean.hefty@intel.com>
Signed-off-by: Michael Wang <yun.wang@profitbricks.com>
---
 drivers/infiniband/core/cma.c      |  2 +-
 drivers/infiniband/core/sa_query.c |  2 +-
 drivers/infiniband/core/verbs.c    |  4 ++--
 include/rdma/ib_verbs.h            | 15 +++++++++++++++
 4 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index c3dbcdd..2e96883 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -711,7 +711,7 @@ static int cma_ib_init_qp_attr(struct rdma_id_private *id_priv,
 	int ret;
 	u16 pkey;
 
-	if (rdma_protocol_iboe(id_priv->id.device, id_priv->id.port_num))
+	if (cap_eth_ah(id_priv->id.device, id_priv->id.port_num))
 		pkey = 0xffff;
 	else
 		pkey = ib_addr_get_pkey(dev_addr);
diff --git a/drivers/infiniband/core/sa_query.c b/drivers/infiniband/core/sa_query.c
index c82aa48..1f0d009 100644
--- a/drivers/infiniband/core/sa_query.c
+++ b/drivers/infiniband/core/sa_query.c
@@ -540,7 +540,7 @@ int ib_init_ah_from_path(struct ib_device *device, u8 port_num,
 	ah_attr->port_num = port_num;
 	ah_attr->static_rate = rec->rate;
 
-	force_grh = rdma_protocol_iboe(device, port_num);
+	force_grh = cap_eth_ah(device, port_num);
 
 	if (rec->hop_limit > 1 || force_grh) {
 		ah_attr->ah_flags = IB_AH_GRH;
diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c
index 7dd2f51..db1139f 100644
--- a/drivers/infiniband/core/verbs.c
+++ b/drivers/infiniband/core/verbs.c
@@ -200,7 +200,7 @@ int ib_init_ah_from_wc(struct ib_device *device, u8 port_num, struct ib_wc *wc,
 	int ret;
 
 	memset(ah_attr, 0, sizeof *ah_attr);
-	if (rdma_protocol_iboe(device, port_num)) {
+	if (cap_eth_ah(device, port_num)) {
 		if (!(wc->wc_flags & IB_WC_GRH))
 			return -EPROTOTYPE;
 
@@ -869,7 +869,7 @@ int ib_resolve_eth_l2_attrs(struct ib_qp *qp,
 	union ib_gid  sgid;
 
 	if ((*qp_attr_mask & IB_QP_AV)  &&
-	    (rdma_protocol_iboe(qp->device, qp_attr->ah_attr.port_num))) {
+	    (cap_eth_ah(qp->device, qp_attr->ah_attr.port_num))) {
 		ret = ib_query_gid(qp->device, qp_attr->ah_attr.port_num,
 				   qp_attr->ah_attr.grh.sgid_index, &sgid);
 		if (ret)
diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
index c045be1..c724114 100644
--- a/include/rdma/ib_verbs.h
+++ b/include/rdma/ib_verbs.h
@@ -1880,6 +1880,21 @@ static inline int cap_af_ib(struct ib_device *device, u8 port_num)
 }
 
 /**
+ * cap_eth_ah - Check if the port of device has the capability
+ * Ethernet Address Handler.
+ *
+ * @device: Device to be checked
+ * @port_num: Port number of the device
+ *
+ * Return 0 when port of the device don't support
+ * Ethernet Address Handler.
+ */
+static inline int cap_eth_ah(struct ib_device *device, u8 port_num)
+{
+	return rdma_protocol_iboe(device, port_num);
+}
+
+/**
  * cap_read_multi_sge - Check if the port of device has the capability
  * RDMA Read Multiple Scatter-Gather Entries.
  *
-- 
2.1.0


  parent reply	other threads:[~2015-04-28 15:11 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-28 15:10 [PATCH v7 00/23] IB/Verbs: IB Management Helpers Michael Wang
2015-04-28 15:10 ` [PATCH v7 01/23] IB/Verbs: Implement new callback query_protocol() Michael Wang
2015-04-28 15:10 ` [PATCH v7 02/23] IB/Verbs: Implement raw management helpers Michael Wang
2015-04-28 15:10 ` [PATCH v7 03/23] IB/Verbs: Reform IB-core mad/agent/user_mad Michael Wang
2015-04-28 15:10 ` [PATCH v7 04/23] IB/Verbs: Reform IB-core cm Michael Wang
2015-04-28 19:02   ` Or Gerlitz
2015-04-29  7:40     ` Michael Wang
2015-04-29  8:17       ` Or Gerlitz
2015-04-29 15:48       ` Or Gerlitz
2015-04-30  7:28         ` Michael Wang
2015-04-28 15:10 ` [PATCH v7 05/23] IB/Verbs: Reform IB-core sa_query Michael Wang
2015-04-28 15:10 ` [PATCH v7 06/23] IB/Verbs: Reform IB-core multicast Michael Wang
2015-04-28 15:10 ` [PATCH v7 07/23] IB/Verbs: Reform IB-ulp ipoib Michael Wang
2015-04-28 15:10 ` [PATCH v7 08/23] IB/Verbs: Reform IB-ulp xprtrdma Michael Wang
2015-04-28 15:10 ` [PATCH v7 09/23] IB/Verbs: Reform IB-core verbs Michael Wang
2015-04-28 15:10 ` [PATCH v7 10/23] IB/Verbs: Reform cm related part in IB-core cma/ucm Michael Wang
2015-04-28 15:10 ` [PATCH v7 11/23] IB/Verbs: Reform route related part in IB-core cma Michael Wang
2015-04-28 15:10 ` [PATCH v7 12/23] IB/Verbs: Reform mcast " Michael Wang
2015-04-28 15:10 ` [PATCH v7 13/23] IB/Verbs: Reform cma_acquire_dev() Michael Wang
2015-04-28 15:10 ` [PATCH v7 14/23] IB/Verbs: Reform rest part in IB-core cma Michael Wang
2015-04-28 15:10 ` [PATCH v7 15/23] IB/Verbs: Use management helper cap_ib_mad() Michael Wang
2015-04-28 15:10 ` [PATCH v7 16/23] IB/Verbs: Use management helper cap_ib_smi() Michael Wang
2015-04-28 15:10 ` [PATCH v7 17/23] IB/Verbs: Use management helper cap_ib_cm() Michael Wang
2015-04-28 15:10 ` [PATCH v7 18/23] IB/Verbs: Use management helper cap_iw_cm() Michael Wang
2015-04-28 15:10 ` [PATCH v7 19/23] IB/Verbs: Use management helper cap_ib_sa() Michael Wang
2015-04-28 15:10 ` [PATCH v7 20/23] IB/Verbs: Use management helper cap_ib_mcast() Michael Wang
2015-04-28 15:10 ` [PATCH v7 21/23] IB/Verbs: Use management helper cap_read_multi_sge() Michael Wang
2015-04-28 15:10 ` [PATCH v7 22/23] IB/Verbs: Use management helper cap_af_ib() Michael Wang
2015-04-28 15:10 ` Michael Wang [this message]
2015-04-29 16:28 ` [PATCH v7 00/23] IB/Verbs: IB Management Helpers Doug Ledford
2015-04-30  7:48   ` Michael Wang
2015-05-01  6:34 ` ira.weiny
2015-05-01 16:24   ` Hefty, Sean
2015-05-01 16:27     ` Weiny, Ira
2015-05-04  7:36   ` Michael Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430233823-7075-24-git-send-email-yun.wang@profitbricks.com \
    --to=yun.wang@profitbricks.com \
    --cc=Devesh.Sharma@Emulex.Com \
    --cc=dgoodell@cisco.com \
    --cc=dledford@redhat.com \
    --cc=eli@mellanox.com \
    --cc=faisal.latif@intel.com \
    --cc=haggaie@mellanox.com \
    --cc=hal@dev.mellanox.co.il \
    --cc=hnguyen@de.ibm.com \
    --cc=infinipath@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=jackm@dev.mellanox.co.il \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=liranl@mellanox.com \
    --cc=ogerlitz@mellanox.com \
    --cc=raisch@de.ibm.com \
    --cc=roland@kernel.org \
    --cc=sean.hefty@intel.com \
    --cc=swise@opengridcomputing.com \
    --cc=tom@opengridcomputing.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®