mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Shelton <ben.shelton@ni.com>
To: dwmw2@infradead.org, computersforpeace@gmail.com,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Jeff Westfahl <jeff.westfahl@ni.com>
Subject: [PATCH] mtd: Introduce CONFIG_MTD_RESERVE_END
Date: Wed, 29 Apr 2015 14:28:02 -0500	[thread overview]
Message-ID: <1430335682-6174-1-git-send-email-ben.shelton@ni.com> (raw)

From: Jeff Westfahl <jeff.westfahl@ni.com>

Add a new config parameter CONFIG_MTD_RESERVE_END. This is used with
command line partition parsing to reserve space at the end of a
partition defined with a size of '-', which indicates it should use all
remaining space.

Signed-off-by: Jeff Westfahl <jeff.westfahl@ni.com>
---
 drivers/mtd/Kconfig       | 24 ++++++++++++++++++++++++
 drivers/mtd/cmdlinepart.c |  3 ++-
 2 files changed, 26 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
index a03ad29..f7df08c 100644
--- a/drivers/mtd/Kconfig
+++ b/drivers/mtd/Kconfig
@@ -110,6 +110,30 @@ config MTD_CMDLINE_PARTS
 
 	  If unsure, say 'N'.
 
+config MTD_RESERVE_END
+	int "Reserved space at the end of an all remaining space partition"
+	depends on MTD_CMDLINE_PARTS = "y"
+	default 0
+	---help---
+	  Specify an amount of reserved space at the end of the last MTD
+	  partition when the size is specified with '-' to denote all
+	  remaining space.
+
+	  This can be useful if, for example, the BBT is stored at the end
+	  of the flash, and you don't want those blocks counted as part of
+	  the last MTD partition. This is less heavyweight than reserving
+	  the BBT blocks with a separate MTD partition. The BBT marks its
+	  own blocks as bad blocks, which prevents an MTD driver such as
+	  UBI from getting an accurate count of the actual bad blocks in
+	  the MTD partition that contains the BBT.
+
+	  The value is specified in bytes. As an example, a typical BBT
+	  reserves four erase blocks, and a typical erase block size is
+	  128kB. To reserve that much space at the end of the flash, the
+	  value for this config option would be 524288.
+
+	  If unsure, use the default value of zero.
+
 config MTD_AFS_PARTS
 	tristate "ARM Firmware Suite partition parsing"
 	depends on ARM
diff --git a/drivers/mtd/cmdlinepart.c b/drivers/mtd/cmdlinepart.c
index c850300..9b83c1a 100644
--- a/drivers/mtd/cmdlinepart.c
+++ b/drivers/mtd/cmdlinepart.c
@@ -340,7 +340,8 @@ static int parse_cmdline_partitions(struct mtd_info *master,
 			offset = part->parts[i].offset;
 
 		if (part->parts[i].size == SIZE_REMAINING)
-			part->parts[i].size = master->size - offset;
+			part->parts[i].size = master->size - offset -
+					      CONFIG_MTD_RESERVE_END;
 
 		if (offset + part->parts[i].size > master->size) {
 			printk(KERN_WARNING ERRP
-- 
2.3.7


             reply	other threads:[~2015-04-29 19:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-29 19:28 Ben Shelton [this message]
2015-04-29 21:46 ` Brian Norris
2015-04-30 17:36   ` Ben Shelton
2015-05-01 11:57     ` Jonas Gorski
2015-05-07  3:27       ` Brian Norris
2015-04-30 22:02 ` Paul Bolle
2015-04-30 22:46   ` Ben Shelton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430335682-6174-1-git-send-email-ben.shelton@ni.com \
    --to=ben.shelton@ni.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=jeff.westfahl@ni.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®