From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Cc: Akinobu Mita <akinobu.mita@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
sparclinux@vger.kernel.org, linux-arch@vger.kernel.org
Subject: [PATCH v2 09/10] sparc: use for_each_sg()
Date: Fri, 1 May 2015 22:56:42 +0900 [thread overview]
Message-ID: <1430488603-11055-9-git-send-email-akinobu.mita@gmail.com> (raw)
In-Reply-To: <1430488603-11055-1-git-send-email-akinobu.mita@gmail.com>
This replaces the plain loop over the sglist array with for_each_sg()
macro which consists of sg_next() function calls. Since sparc does
select ARCH_HAS_SG_CHAIN, it is necessary to use for_each_sg() in
order to loop over each sg element. This also help find problems with
drivers that do not properly initialize their sg tables when
CONFIG_DEBUG_SG is enabled.
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org
Cc: linux-arch@vger.kernel.org
---
* New patch from v2
arch/sparc/kernel/ldc.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/arch/sparc/kernel/ldc.c b/arch/sparc/kernel/ldc.c
index 7d3ca30..1ae5eb1 100644
--- a/arch/sparc/kernel/ldc.c
+++ b/arch/sparc/kernel/ldc.c
@@ -2086,6 +2086,7 @@ int ldc_map_sg(struct ldc_channel *lp,
struct cookie_state state;
struct ldc_iommu *iommu;
int err;
+ struct scatterlist *s;
if (map_perm & ~LDC_MAP_ALL)
return -EINVAL;
@@ -2112,9 +2113,10 @@ int ldc_map_sg(struct ldc_channel *lp,
state.pte_idx = (base - iommu->page_table);
state.nc = 0;
- for (i = 0; i < num_sg; i++)
- fill_cookies(&state, page_to_pfn(sg_page(&sg[i])) << PAGE_SHIFT,
- sg[i].offset, sg[i].length);
+ for_each_sg(sg, s, num_sg, i) {
+ fill_cookies(&state, page_to_pfn(sg_page(s)) << PAGE_SHIFT,
+ s->offset, s->length);
+ }
return state.nc;
}
--
1.9.1
next prev parent reply other threads:[~2015-05-01 13:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 13:56 [PATCH v2 01/10] m68k: " Akinobu Mita
2015-05-01 13:56 ` [PATCH v2 02/10] arc: " Akinobu Mita
2015-05-01 13:56 ` [PATCH v2 03/10] metag: " Akinobu Mita
2015-05-01 13:56 ` [PATCH v2 04/10] xtensa: " Akinobu Mita
2015-05-01 13:56 ` [PATCH v2 05/10] mips: " Akinobu Mita
2015-05-01 13:56 ` [PATCH v2 06/10] frv: " Akinobu Mita
2015-05-01 13:56 ` [PATCH v2 07/10] avr32: " Akinobu Mita
2015-05-04 6:15 ` Hans-Christian Egtvedt
2015-05-01 13:56 ` [PATCH v2 08/10] powerpc: " Akinobu Mita
2015-05-01 13:56 ` Akinobu Mita [this message]
2015-05-01 13:56 ` [PATCH v2 10/10] parisc: " Akinobu Mita
2015-05-04 9:04 ` [PATCH v2 01/10] m68k: " Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430488603-11055-9-git-send-email-akinobu.mita@gmail.com \
--to=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®