From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751540AbbEBAtF (ORCPT ); Fri, 1 May 2015 20:49:05 -0400 Received: from mail.kernel.org ([198.145.29.136]:50586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823AbbEBAtD (ORCPT ); Fri, 1 May 2015 20:49:03 -0400 From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [PATCH 01/19] f2fs: fix not to check IS_ERR for null pointer Date: Fri, 1 May 2015 17:48:28 -0700 Message-Id: <1430527726-68547-1-git-send-email-jaegeuk@kernel.org> X-Mailer: git-send-email 2.1.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The acl can have null, error pointer, or valid pointer. So, we should check its pointer existence too. Signed-off-by: Jaegeuk Kim --- fs/f2fs/acl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c index c8f25f7..851ff98 100644 --- a/fs/f2fs/acl.c +++ b/fs/f2fs/acl.c @@ -190,7 +190,7 @@ static struct posix_acl *__f2fs_get_acl(struct inode *inode, int type, acl = ERR_PTR(retval); kfree(value); - if (!IS_ERR(acl)) + if (!IS_ERR_OR_NULL(acl)) set_cached_acl(inode, type, acl); return acl; -- 2.1.1