From: Jiri Slaby <jslaby@suse.cz>
To: live-patching@vger.kernel.org
Cc: jpoimboe@redhat.com, sjenning@redhat.com, jkosina@suse.cz,
vojtech@suse.cz, mingo@redhat.com, linux-kernel@vger.kernel.org,
Jiri Slaby <jslaby@suse.cz>
Subject: [RFC kgr on klp 7/9] livepatch: propagate the patch status to functions
Date: Mon, 4 May 2015 13:40:23 +0200 [thread overview]
Message-ID: <1430739625-4658-7-git-send-email-jslaby@suse.cz> (raw)
In-Reply-To: <1430739625-4658-1-git-send-email-jslaby@suse.cz>
We will need to propagate few different target states in the next
patch adding kgraft-like patching. And this will make it easy. So this
is only a preparation which does not really change the behaviour.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---
kernel/livepatch/core.c | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index 87d94aadfebf..5e89ea74cadb 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -330,7 +330,7 @@ static void notrace klp_ftrace_handler(unsigned long ip,
rcu_read_unlock();
}
-static void klp_disable_func(struct klp_func *func)
+static void klp_disable_func(struct klp_func *func, enum klp_state dstate)
{
struct klp_ops *ops;
@@ -354,7 +354,7 @@ static void klp_disable_func(struct klp_func *func)
list_del_rcu(&func->stack_node);
}
- func->state = KLP_DISABLED;
+ func->state = dstate;
}
static int klp_prepare_enable_func(struct klp_func *func)
@@ -410,7 +410,7 @@ err:
return ret;
}
-static void klp_enable_func(struct klp_func *func)
+static void klp_enable_func(struct klp_func *func, enum klp_state dstate)
{
struct klp_ops *ops;
@@ -420,18 +420,18 @@ static void klp_enable_func(struct klp_func *func)
list_add_rcu(&func->stack_node, &ops->func_stack);
- func->state = KLP_ENABLED;
+ func->state = dstate;
}
-static void klp_disable_object(struct klp_object *obj)
+static void klp_disable_object(struct klp_object *obj, enum klp_state dstate)
{
struct klp_func *func;
klp_for_each_func(obj, func)
if (func->state != KLP_DISABLED)
- klp_disable_func(func);
+ klp_disable_func(func, dstate);
- obj->state = KLP_DISABLED;
+ obj->state = dstate;
}
static int klp_prepare_enable_object(struct klp_object *obj)
@@ -448,7 +448,7 @@ static int klp_prepare_enable_object(struct klp_object *obj)
klp_for_each_func(obj, func) {
ret = klp_prepare_enable_func(func);
if (ret) {
- klp_disable_object(obj);
+ klp_disable_object(obj, KLP_DISABLED);
return ret;
}
}
@@ -457,14 +457,14 @@ static int klp_prepare_enable_object(struct klp_object *obj)
return 0;
}
-static void klp_enable_object(struct klp_object *obj)
+static void klp_enable_object(struct klp_object *obj, enum klp_state dstate)
{
struct klp_func *func;
klp_for_each_func(obj, func)
- klp_enable_func(func);
+ klp_enable_func(func, dstate);
- obj->state = KLP_ENABLED;
+ obj->state = dstate;
}
static int __klp_disable_patch(struct klp_patch *patch)
@@ -480,7 +480,7 @@ static int __klp_disable_patch(struct klp_patch *patch)
klp_for_each_object(patch, obj) {
if (obj->state == KLP_PREPARED || obj->state == KLP_ENABLED)
- klp_disable_object(obj);
+ klp_disable_object(obj, KLP_DISABLED);
}
patch->state = KLP_DISABLED;
@@ -551,7 +551,7 @@ static int __klp_enable_patch(struct klp_patch *patch)
if (!klp_is_object_loaded(obj))
continue;
- klp_enable_object(obj);
+ klp_enable_object(obj, KLP_ENABLED);
}
patch->state = KLP_ENABLED;
@@ -964,7 +964,7 @@ static void klp_module_notify_coming(struct klp_patch *patch,
if (ret)
goto err;
- klp_enable_object(obj);
+ klp_enable_object(obj, KLP_ENABLED);
return;
err:
@@ -984,7 +984,7 @@ static void klp_module_notify_going(struct klp_patch *patch,
pr_notice("reverting patch '%s' on unloading module '%s'\n",
pmod->name, mod->name);
- klp_disable_object(obj);
+ klp_disable_object(obj, KLP_DISABLED);
disabled:
klp_free_object_loaded(obj);
--
2.3.5
next prev parent reply other threads:[~2015-05-04 11:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 11:40 [RFC kgr on klp 1/9] livepatch: make kobject in klp_object statically allocated Jiri Slaby
2015-05-04 11:40 ` [RFC kgr on klp 2/9] livepatch: introduce patch/func-walking helpers Jiri Slaby
2015-05-04 11:40 ` [RFC kgr on klp 3/9] livepatch: add klp_*_to_patch helpers Jiri Slaby
2015-05-04 11:40 ` [RFC kgr on klp 4/9] livepatch: add kgr infrastructure Jiri Slaby
2015-05-04 12:23 ` Martin Schwidefsky
2015-05-05 13:27 ` Jiri Slaby
2015-05-05 14:34 ` Martin Schwidefsky
2015-05-04 11:40 ` [RFC kgr on klp 5/9] livepatch: teach klp about consistency models Jiri Slaby
2015-05-04 11:40 ` [RFC kgr on klp 6/9] livepatch: do not allow failure while really patching Jiri Slaby
2015-05-04 11:40 ` Jiri Slaby [this message]
2015-05-04 11:40 ` [RFC kgr on klp 8/9] livepatch: add kgraft-like patching Jiri Slaby
2015-05-04 11:40 ` [RFC kgr on klp 9/9] livepatch: send a fake signal to all tasks Jiri Slaby
2015-05-04 14:34 ` Oleg Nesterov
2015-05-06 12:58 ` Miroslav Benes
2015-05-04 12:20 ` [RFC kgr on klp 0/9] kGraft on the top of KLP Jiri Slaby
2015-05-04 15:44 ` Josh Poimboeuf
2015-05-04 22:48 ` Jiri Kosina
2015-05-05 3:43 ` Josh Poimboeuf
2015-05-05 6:14 ` Jiri Kosina
2015-05-05 16:24 ` Josh Poimboeuf
2015-05-12 9:45 ` Jiri Kosina
2015-05-12 15:20 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430739625-4658-7-git-send-email-jslaby@suse.cz \
--to=jslaby@suse.cz \
--cc=jkosina@suse.cz \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®